Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DH-4703 Set table-desription status #183

Merged
merged 2 commits into from
Sep 25, 2023
Merged

DH-4703 Set table-desription status #183

merged 2 commits into from
Sep 25, 2023

Conversation

jcjc712
Copy link
Contributor

@jcjc712 jcjc712 commented Sep 25, 2023

No description provided.

@jcjc712 jcjc712 force-pushed the DH-4703 branch 2 times, most recently from f7ec6cf to 345d97b Compare September 25, 2023 19:39
Copy link
Contributor

@aazo11 aazo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs need to be updated. Also I believe we should add some automated tests as well to cover the new async logic.

dataherald/api/fastapi.py Show resolved Hide resolved
@jcjc712
Copy link
Contributor Author

jcjc712 commented Sep 25, 2023

The docs need to be updated. Also I believe we should add some automated tests as well to cover the new async logic.

Yes, working on that

@jcjc712 jcjc712 merged commit 9e2d119 into main Sep 25, 2023
@jcjc712 jcjc712 deleted the DH-4703 branch September 25, 2023 23:13
DishenWang2023 pushed a commit that referenced this pull request May 7, 2024
* DH-4703 Set table-desription status

* DH-4703 Added script to update table_descriptions rows
DishenWang2023 added a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants