DH-4724/adding support for db level instructions #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aazo11
reviewed
Sep 26, 2023
| @@ -19,6 +19,13 @@ def __init__(self, system: System): | |||
| "ssh_settings": None, | |||
| } | |||
| ] | |||
| self.memory["instructions"] = [ | |||
| { | |||
| "_id": "64dfa0e103f5134086f7090c", | |||
There was a problem hiding this comment.
I see we are adding an instruction but are we testing the 4 new instruction endpoints?
There was a problem hiding this comment.
@aazo11 we basically don't test the instructions, all of the pytests that we have are only empty classes, almost for all of the classes
jcjc712
reviewed
Sep 27, 2023
jcjc712
suggested changes
Sep 27, 2023
jcjc712
reviewed
Sep 27, 2023
jcjc712
approved these changes
Sep 27, 2023
jcjc712
reviewed
Sep 27, 2023
README.md
Outdated
|
|
||
| ``` | ||
| curl -X 'GET' \ | ||
| '<host>/api/v1/instructions?page=1&limit=10' \ |
There was a problem hiding this comment.
you can set db_connection_id here '/api/v1/instructions?page=1&limit=10&db_connection_id=12312312'
jcjc712
reviewed
Sep 27, 2023
docs/api.list_instructions.rst
Outdated
| .. code-block:: rst | ||
|
|
||
| curl -X 'GET' \ | ||
| '<host>/api/v1/instructions?page=1&limit=10' \ |
There was a problem hiding this comment.
Set db_connection_id as query param
MohammadrezaPourreza
deleted the
DH-4724/adding_support_for_instructions
branch
DishenWang2023
pushed a commit
that referenced
this pull request
May 7, 2024
* DH-4724/adding support for db level instructions * DH-4724/chanign the database tests * DH-4724/changing the find_all() function * DH-4724/changing the tests * DH-4724/adding find_by method to instructionRepo * DH-4724/reformat * DH-4724/add paginating to the db * DH-4724/reformat with black * DH-4724/updating the endpoints to be RESTfull * DH-4724/reformat with black * DH-4724/changing the docs
DishenWang2023
pushed a commit
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.