Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PUT /api/v1/database-connections/<conn_id> request #513

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

b-tsao
Copy link

@b-tsao b-tsao commented Jun 20, 2024

The update database-connections api was broken by this PR 31b88df after adding support for schemas

Where the response to the call would be

{"error_code":"invalid_database_connection","message":"'list' object has no attribute 'items'","description":null,"detail":{"alias":"SomeAlias","use_ssh":false,"connection_uri":"gAAAAABmcios2gjJ4CI9-D7jd5vjIuA1fqzC3HGGBQOlxKn4-TGdKSH6X4nmy0onQgJ9WNWJlp79LHwzE0Che12aQ2T7eiV2q3XgI6g4KAc46FBG9keA0SyO-PLpRc4Ewa1y39sSfqCq4S_T05OF_ZVNVWqpHpVJ3rIXQLFsRKyB-YThpJKCyws=","schemas":null,"path_to_credentials_file":null,"llm_api_key":null,"ssh_settings":null,"file_storage":null}}

@b-tsao b-tsao changed the title Add Db2(z) support for POST /api/v1/database-connections and fix PUT /api/v1/database-connections/<conn_id> request Fix PUT /api/v1/database-connections/<conn_id> request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant