Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi exchange broker mappings #9

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

sandroboehme
Copy link
Contributor

As promised, this is the PR for #7 "Enhance the broker mappings and store them for multiple exchanges". But it's a bigger one.
There one thing I'm not sure about: As I extend the Binance specific broker from CCXTBroker I wanted to avoid that it registers with the CCXTStore as well which is why I've prevented that with if name == 'CCXTBroker': like this:

class MetaCCXTBroker(BrokerBase.__class__):
    def __init__(cls, name, bases, dct):
        '''Class has already been created ... register'''
        # Initialize the class
        super(MetaCCXTBroker, cls).__init__(name, bases, dct)
        if name == 'CCXTBroker':
            CCXTStore.BrokerCls = cls

sandroboehme and others added 6 commits March 6, 2019 16:26
…) method

o added the symbol for cancel_order()
o added sell order examples for Binance
o moved the Binance examples to the ‚binance‘ folder
Added a new debug parameter for the broker. 

This will allow pretty printing of rest responses and should make broker mapping easier.
@Dave-Vallance
Copy link
Owner

@sandroboehme Amazing stuff... Will try to review after I look at the feeds

@armezit
Copy link

armezit commented Aug 6, 2021

@Dave-Vallance Any chance for this pull request to be merged into the master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants