Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use textContent instead of innerHTML #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use textContent instead of innerHTML #108

wants to merge 1 commit into from

Conversation

theboolean
Copy link

Using innerHTML will expose the library to the possibility of cross site scripting and HTML injection, textContent will instead use string passed as-is without parsing it as HTML.
Note that textContent is the default behaviour of polymer.

cc @leogr that helped me discovering and fixing this issue.

@theboolean
Use textContent instead of innerHTML
40844bb 
Using textContent will avoid the possibility of cross site scripting and HTML injection
@theboolean
Copy link
Author

@David-Mulder any news about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theboolean