Adding mixins for paper checkbox size #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although paper datatable has the mixins --paper-datatable-column-header and --paper-datatable-cell through which we can customize header and cell styles eg: padding/height etc, but in case of selectable checkbox this fails as the height of the row increases to adjust the checkbox size.
However checkbox size in itself is a mixin from paper-checkbox(--paper-checkbox-size) but here --paper-datatable-checkbox and --paper-datatable-header-checkbox don't help because of the nested mixin issue as addressed in polymer#3746.
Hence adding two new mixin variable as --paper-datatable-header-checkbox-size and --paper-datatable-checkbox-size so that checkbox size can be passed. If variable not passed it will be default by paper checkbox as 18px. Also adjusting the size of the partialSelectionContainer class to adjust as the checkbox provided size.
A very straight-forward and simple pull request but helps in styling as height 56px is too much of real-estate for a field in custom styling. Hope it helps.