feat: add --help flag #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Thanks, I'll look at this in more detail soon! Very briefly, I would prefer to leave the if/else if in place and suppress the new lint warning. Also, the new parameter should be added to the help output (which will require snapshot updates) and the copy of it in the README. |
boneskull
force-pushed
the
boneskull/issue249
branch
from
5bedd68 to
5f6e326
Compare
|
@DavidAnson I've done as requested |
…ixes DavidAnson#249). also reverts some conditional changes and suppresses an eslint rule
DavidAnson
force-pushed
the
boneskull/issue249
branch
from
5f6e326 to
9ff2ffc
Compare
DavidAnson
force-pushed
the
boneskull/issue249
branch
from
9ff2ffc to
3f0be36
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--helpflag which takes precedence over all other arguments or positionals.Closes #249
I wasn't sure how/where you'd like to see a test for this sort of thing, so I just gave it a shot.
I changed the
else ifs to individualifstatements because ESLint ("unicorn" plugin) started complaining that I should be using aswitchstatement. It's not wrong, necessarily--but that's why I did what I did.