feat: deal get persons endpoint

readme.md

@@ -62,7 +62,7 @@ You can debug this library right from your application by configuring the [NuGet
   - [x] getDealMailMessages
   - [x] getDealParticipants
   - [ ] getDealUsers
-  - [ ] getDealPersons
+  - [x] getDealPersons
   - [x] getDealProducts
   - [x] addDeal
   - [ ] duplicateDeal

src/Pipedrive.net.Tests.Integration/Clients/DealsClientTests.cs

@@ -554,6 +554,65 @@ public async Task ReturnsDistinctInfosBasedOnStartPage()
             }
         }
 
+        public class TheGetPersonsMethod
+        {
+            [IntegrationTest]
+            public async Task ReturnsCorrectCountWithoutStart()
+            {
+                var pipedrive = Helper.GetAuthenticatedClient();
+
+                var options = new DealPersonFilters
+                {
+                    PageSize = 3,
+                    PageCount = 1
+                };
+
+                var dealPersons = await pipedrive.Deal.GetPersons(4, options);
+                Assert.Equal(3, dealPersons.Count);
+            }
+
+            [IntegrationTest]
+            public async Task ReturnsCorrectCountWithStart()
+            {
+                var pipedrive = Helper.GetAuthenticatedClient();
+
+                var options = new DealPersonFilters
+                {
+                    PageSize = 2,
+                    PageCount = 1,
+                    StartPage = 1
+                };
+
+                var dealPersons = await pipedrive.Deal.GetPersons(4, options);
+                Assert.Equal(2, dealPersons.Count);
+            }
+
+            [IntegrationTest]
+            public async Task ReturnsDistinctInfosBasedOnStartPage()
+            {
+                var pipedrive = Helper.GetAuthenticatedClient();
+
+                var startOptions = new DealPersonFilters
+                {
+                    PageSize = 1,
+                    PageCount = 1
+                };
+
+                var firstPage = await pipedrive.Deal.GetPersons(4, startOptions);
+
+                var skipStartOptions = new DealPersonFilters
+                {
+                    PageSize = 1,
+                    PageCount = 1,
+                    StartPage = 1
+                };
+
+                var secondPage = await pipedrive.Deal.GetPersons(4, skipStartOptions);
+
+                Assert.NotEqual(firstPage[0].Id, secondPage[0].Id);
+            }
+        }
+
         public class TheGetParticipantsMethod
         {
             [IntegrationTest]

src/Pipedrive.net.Tests/Clients/DealsClientTests.cs

@@ -576,6 +576,43 @@ await connection.GetAll<DealActivity>(
             }
         }
 
+        public class TheGetPersonsMethod
+        {
+            [Fact]
+            public async Task EnsuresNonNullArguments()
+            {
+                var client = new DealsClient(Substitute.For<IApiConnection>());
+
+                await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetPersons(1, null));
+            }
+
+            [Fact]
+            public async Task RequestsCorrectUrl()
+            {
+                var connection = Substitute.For<IApiConnection>();
+                var client = new DealsClient(connection);
+
+                var filters = new DealPersonFilters
+                {
+                    PageSize = 1,
+                    PageCount = 1,
+                    StartPage = 0,
+                };
+
+                await client.GetPersons(123, filters);
+
+                Received.InOrder(async () =>
+                {
+                    await connection.GetAll<Person>(
+                        Arg.Is<Uri>(u => u.ToString() == "deals/123/persons"),
+                        Arg.Is<Dictionary<string, string>>(d => d.Count == 0),
+                        Arg.Is<ApiOptions>(o => o.PageSize == 1
+                                && o.PageCount == 1
+                                && o.StartPage == 0));
+                });
+            }
+        }
+
         public class TheGetParticipantsMethod
         {
             [Fact]
@@ -605,8 +642,7 @@ public async Task RequestsCorrectUrl()
                 {
                     await connection.GetAll<DealParticipant>(
                         Arg.Is<Uri>(u => u.ToString() == "deals/123/participants"),
-                        Arg.Is<Dictionary<string, string>>(d => d.Count == 1
-                            && d["id"] == "123"),
+                        Arg.Is<Dictionary<string, string>>(d => d.Count == 0),
                         Arg.Is<ApiOptions>(o => o.PageSize == 1
                                 && o.PageCount == 1
                                 && o.StartPage == 0));

src/Pipedrive.net/Clients/DealsClient.cs

@@ -227,12 +227,26 @@ public Task<IReadOnlyList<DealActivity>> GetActivities(long dealId, DealActivity
             return ApiConnection.GetAll<DealActivity>(ApiUrls.DealActivities(dealId), parameters, options);
         }
 
+        public Task<IReadOnlyList<Person>> GetPersons(long dealId, DealPersonFilters filters)
+        {
+            Ensure.ArgumentNotNull(filters, nameof(filters));
+
+            var parameters = filters.Parameters;
+            var options = new ApiOptions
+            {
+                StartPage = filters.StartPage,
+                PageCount = filters.PageCount,
+                PageSize = filters.PageSize
+            };
+
+            return ApiConnection.GetAll<Person>(ApiUrls.DealPersons(dealId), parameters, options);
+        }
+
         public Task<IReadOnlyList<DealParticipant>> GetParticipants(long dealId, DealParticipantFilters filters)
         {
             Ensure.ArgumentNotNull(filters, nameof(filters));
 
             var parameters = filters.Parameters;
-            parameters.Add("id", dealId.ToString());
             var options = new ApiOptions
             {
                 StartPage = filters.StartPage,

src/Pipedrive.net/Clients/IDealsClient.cs

@@ -46,6 +46,8 @@ public interface IDealsClient
 
         Task<IReadOnlyList<DealActivity>> GetActivities(long dealId, DealActivityFilters filters);
 
+        Task<IReadOnlyList<Person>> GetPersons(long dealId, DealPersonFilters filters);
+
         Task<IReadOnlyList<DealParticipant>> GetParticipants(long dealId, DealParticipantFilters filters);
 
         Task<DealParticipant> AddParticipant(long dealId, long personId);

src/Pipedrive.net/Helpers/ApiUrls.cs

@@ -195,6 +195,15 @@ public static Uri DealActivities(long id)
             return new Uri($"deals/{id}/activities", UriKind.Relative);
         }
 
+        /// <summary>
+        /// Returns the <see cref="Uri"/> for all the persons of the specified deal.
+        /// </summary>
+        /// <param name="id">The id of the deal</param>
+        public static Uri DealPersons(long id)
+        {
+            return new Uri($"deals/{id}/persons", UriKind.Relative);
+        }
+
         /// <summary>
         /// Returns the <see cref="Uri"/> for all the participants of the specified deal.
         /// </summary>

src/Pipedrive.net/Models/Request/Deals/DealPersonFilters.cs

@@ -0,0 +1,30 @@
+using System.Collections.Generic;
+
+namespace Pipedrive
+{
+    public class DealPersonFilters
+    {
+        public static DealPersonFilters None
+        {
+            get { return new DealPersonFilters(); }
+        }
+
+        public int? StartPage { get; set; }
+
+        public int? PageCount { get; set; }
+
+        public int? PageSize { get; set; }
+
+        /// <summary>
+        /// Get the query parameters that will be appending onto the search
+        /// </summary>
+        public IDictionary<string, string> Parameters
+        {
+            get
+            {
+                var d = new Dictionary<string, string>();
+                return d;
+            }
+        }
+    }
+}