Skip to content

Commit

Permalink
Avoid R CMD Check false alarms (#74)
Browse files Browse the repository at this point in the history
* Avoid R CMD Check false alarms

* NEWS bullet

* Tag PR number
  • Loading branch information
DavisVaughan authored May 27, 2020
1 parent 2bffe93 commit d898586
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
2 changes: 2 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ export(workdays)
export(yearly)
import(rlang)
import(vctrs)
importFrom(R6,R6Class)
importFrom(V8,v8)
importFrom(glue,glue)
importFrom(magrittr,"%>%")
useDynLib(almanac, .registration = TRUE)
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# almanac (development version)

* Explicitly imports `R6::R6Class()` and `V8::v8()` to avoid R CMD Check
false alarms (#74).

* Fix USBAN error of casting `NA_real_` and `NaN` to integer (#72).

# almanac 0.1.0
Expand Down
6 changes: 6 additions & 0 deletions R/almanac-package.R
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
#' @keywords internal
"_PACKAGE"

# We import R6::R6Class() and V8::v8() below to avoid an R CMD Check false alarm
# that states "Namespaces in Imports field not imported from". I guess this
# comes up because we don't call these from inside functions.

# The following block is used by usethis to automatically manage
# roxygen namespace tags. Modify with care!
## usethis namespace: start
#' @import rlang
#' @import vctrs
#' @importFrom glue glue
#' @importFrom R6 R6Class
#' @importFrom V8 v8
#' @useDynLib almanac, .registration = TRUE
## usethis namespace: end
NULL

0 comments on commit d898586

Please sign in to comment.