fix: bind application to start function (#188)

* fix: bind `application` to `start` function Fix #186 * chore: disable `noEmitOnError`
DazzlingFugu · Jun 27, 2022 · 70b02bf · 70b02bf
1 parent 52f7115
commit 70b02bf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/addon/initializers/embedded.ts b/addon/initializers/embedded.ts
@@ -1,6 +1,5 @@
 import Application from '@ember/application'
 import { deprecate } from '@ember/debug'
-import { run } from '@ember/runloop'
 
 interface ObjectConfig {
   delegateStart?:
@@ -102,7 +101,7 @@ export function initialize(application: Application): void {
   if (embeddedConfig.delegateStart) {
     // @ts-ignore: until correct public types are available
     application.reopen({
-      start: run.bind(application, function emberCliEmbeddedStart(config = {}) {
+      start: function emberCliEmbeddedStart(this: Application, config = {}) {
         const _embeddedConfig = Object.assign(
           {},
           embeddedConfig.config,
@@ -112,9 +111,11 @@ export function initialize(application: Application): void {
         this.register('config:embedded', _embeddedConfig, { instantiate: false })
 
         this.advanceReadiness()
-      }),
+      }.bind(application),
     })
+
     application.deferReadiness()
+
   } else {
     application.register('config:embedded', embeddedConfig.config)
   }

diff --git a/tsconfig.json b/tsconfig.json
@@ -10,7 +10,7 @@
     "module": "es6",
     "moduleResolution": "node",
     "noEmit": true,
-    "noEmitOnError": true,
+    // "noEmitOnError": true,
     "noFallthroughCasesInSwitch": true,
     "noImplicitOverride": true,
     "noImplicitReturns": true,