Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ember-5): replaces assign() Ember polyfill #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor(ember-5): replaces assign() Ember polyfill #1

wants to merge 3 commits into from

Conversation

Pixelik
Copy link
Collaborator

@Pixelik Pixelik commented Aug 2, 2023 •
edited
Loading

  • Usage of the assign() Ember polyfill will no longer be allowed in Ember 5.x
  • this commit replaces any occurrences with Object.assign()
  • adds GH workflow that runs test & linter
  • updates ember-try to only run tests against Ember 3.12 (Ember 2.x is too old and tests against Ember 4+ require refactoring)

@Pixelik Pixelik self-assigned this Aug 2, 2023
@Pixelik Pixelik requested a review from ndekeister-us August 2, 2023 11:19
@Pixelik Pixelik changed the title refactor: replaces assign() Ember polyfill refactor(ember-5): replaces assign() Ember polyfill Aug 2, 2023
@Pixelik Pixelik force-pushed the refactor/no-assign-polyfill branch from 164d3c2 to aeb6e55 Compare August 2, 2023 11:38
@Pixelik Pixelik force-pushed the refactor/no-assign-polyfill branch 4 times, most recently from 7ba43fc to e9cf0a2 Compare August 2, 2023 11:49
@Pixelik Pixelik marked this pull request as draft August 2, 2023 12:51
@Pixelik Pixelik removed the request for review from ndekeister-us August 2, 2023 12:51
@Pixelik Pixelik force-pushed the refactor/no-assign-polyfill branch 2 times, most recently from e9cf0a2 to 0250b42 Compare August 2, 2023 13:25
@Pixelik Pixelik force-pushed the refactor/no-assign-polyfill branch from 0250b42 to 7e38c46 Compare August 2, 2023 13:26
@Pixelik Pixelik marked this pull request as ready for review August 2, 2023 13:29
@Pixelik Pixelik requested a review from ndekeister-us August 2, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndekeister-us ndekeister-us Awaiting requested review from ndekeister-us

At least 1 approving review is required to merge this pull request.

Assignees

@Pixelik Pixelik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Pixelik