Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort and remove duplicates from .local.dic #225

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

MrChocolatine
Copy link
Member

Sort and remove duplicates from .local.dic.

@MrChocolatine MrChocolatine requested review from BlueCutOfficial and a team December 16, 2023 16:11
Copy link
Member

@BlueCutOfficial BlueCutOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should have a script available for that, and maybe integrate it into the linter or something. Alphabetical order can be tough to figure out manually on Friday evening 😆

.local.dic Outdated Show resolved Hide resolved
.local.dic Outdated Show resolved Hide resolved
Done by applying the logic:

```js
[ array of terms ].sort().join('\n')
```
Done by applying the logic:

```js
const sorted = arr.concat().sort();
const uniques = [...new Set( sorted )];

uniques.join('\n');
```
@MrChocolatine MrChocolatine force-pushed the sort-and-filter-dictionary branch from d3800c4 to eff0c54 Compare December 18, 2023 11:29
@BlueCutOfficial
Copy link
Member

I prefer that version personally, it looks more readable to me and we can more easily spot duplications.

@MrChocolatine MrChocolatine merged commit c30a6ba into master Dec 18, 2023
2 checks passed
@MrChocolatine MrChocolatine deleted the sort-and-filter-dictionary branch December 18, 2023 11:46
Comment on lines 242 to +243
initializer/nombrable
Initializer/nombrable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For instance, not sure the one with an uppercase I is still useful with /nombrable, we couldn't spot this specific kind of duplication with the initial sorting, so I prefer your new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants