Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes separators logic disparities #199

Merged
merged 4 commits into from
Nov 15, 2023
Merged

fixes separators logic disparities #199

merged 4 commits into from
Nov 15, 2023

Conversation

EvgeniiaVak
Copy link
Member

@EvgeniiaVak EvgeniiaVak commented Nov 10, 2023

fixes #191

  • Removes disparities between separator logic for different components.
  • Removes the separators params from displayAmount function - we don't want users to ever pass something non-standard here (something that is different than the rest of the page). They are not needed for tests, because just mock setup ensures consistent separators.
  • Ensures there is always a thousand separator (because it simplifies code and on macs for some reason even when selecting a number format with spaces - the browser thinks there is no thousands separator, "").

Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for chipper-sunburst-578cfe ready!

Name Link
🔨 Latest commit c5c2a41
🔍 Latest deploy log https://app.netlify.com/sites/chipper-sunburst-578cfe/deploys/65524868d8468d0008167a72
😎 Deploy Preview https://deploy-preview-199--chipper-sunburst-578cfe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EvgeniiaVak EvgeniiaVak marked this pull request as ready for review November 13, 2023 16:04
@EvgeniiaVak EvgeniiaVak merged commit 570e026 into main Nov 15, 2023
4 checks passed
@EvgeniiaVak EvgeniiaVak deleted the fix-separators branch November 15, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Decimals/thousands separator does not work correctly in OrderBook
2 participants