Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prototype env vars #212

Merged
merged 5 commits into from
Jan 10, 2024
Merged

prototype env vars #212

merged 5 commits into from
Jan 10, 2024

Conversation

nguvictor
Copy link
Member

@nguvictor nguvictor commented Jan 1, 2024 •
edited
Loading

Fixes #206

@netlify Netlify
Copy link

netlify bot commented Jan 1, 2024 •
edited
Loading

✅ Deploy Preview for chipper-sunburst-578cfe ready!

Name Link
🔨 Latest commit 1e8142d
🔍 Latest deploy log https://app.netlify.com/sites/chipper-sunburst-578cfe/deploys/659dfb91f1d18b000838bf89
😎 Deploy Preview https://deploy-preview-212--chipper-sunburst-578cfe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EvgeniiaVak
Copy link
Member

@nguvictor do you need help with fixing env vars for .github/workflows/lint-and-test.yml worflow for this PR?

@EvgeniiaVak
Copy link
Member

can we use only NETWORK=stokenet in the env vars (without NETWORK_ID=2), we can then specify in the code which ID to use? (will be easier to test by changing only one variable

@nguvictor nguvictor marked this pull request as ready for review January 9, 2024 02:50
@nguvictor nguvictor requested a review from EvgeniiaVak January 9, 2024 03:29
EvgeniiaVak
EvgeniiaVak requested changes Jan 9, 2024
View reviewed changes
next.config.js Outdated Show resolved Hide resolved
src/app/subscriptions.ts Outdated Show resolved Hide resolved
@nguvictor nguvictor requested a review from EvgeniiaVak January 10, 2024 02:08
EvgeniiaVak
EvgeniiaVak approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@EvgeniiaVak EvgeniiaVak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried locally with mainnet:

NEXT_PUBLIC_NETWORK=mainnet # Options: mainnet or stokenet
NEXT_PUBLIC_DAPP_DEFINITION_ADDRESS=account_rdx168qrzyngejus9nazhp7rw9z3qn2r7uk3ny89m5lwvl299ayv87vpn5

works fine 👍

@EvgeniiaVak EvgeniiaVak merged commit b352d2e into DeXter-on-Radix:main Jan 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvgeniiaVak EvgeniiaVak EvgeniiaVak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment variables for testnet and mainnet urls
2 participants
@nguvictor @EvgeniiaVak