Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rollup from 4.21.3 to 4.22.4 in the npm_and_yarn group across 1 directory #586

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 24, 2024

Bumps the npm_and_yarn group with 1 update in the / directory: rollup.

Updates rollup from 4.21.3 to 4.22.4

Release notes

Sourced from rollup's releases.

v4.22.4

4.22.4

2024-09-21

Bug Fixes

  • Fix a vulnerability in generated code that affects IIFE, UMD and CJS bundles when run in a browser context (#5671)

Pull Requests

v4.22.3

4.22.3

2024-09-21

Bug Fixes

  • Ensure that mutations in modules without side effects are observed while properly handling transitive dependencies (#5669)

Pull Requests

v4.22.2

4.22.2

2024-09-20

Bug Fixes

  • Revert fix for side effect free modules until other issues are investigated (#5667)

Pull Requests

v4.22.1

4.22.1

2024-09-20

Bug Fixes

  • Revert #5644 "stable chunk hashes" while issues are being investigated

Pull Requests

... (truncated)

Changelog

Sourced from rollup's changelog.

4.22.4

2024-09-21

Bug Fixes

  • Fix a vulnerability in generated code that affects IIFE, UMD and CJS bundles when run in a browser context (#5671)

Pull Requests

4.22.3

2024-09-21

Bug Fixes

  • Ensure that mutations in modules without side effects are observed while properly handling transitive dependencies (#5669)

Pull Requests

4.22.2

2024-09-20

Bug Fixes

  • Revert fix for side effect free modules until other issues are investigated (#5667)

Pull Requests

4.22.1

2024-09-20

Bug Fixes

  • Revert #5644 "stable chunk hashes" while issues are being investigated

Pull Requests

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps the npm_and_yarn group with 1 update in the / directory: [rollup](https://github.com/rollup/rollup).


Updates `rollup` from 4.21.3 to 4.22.4
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.21.3...v4.22.4)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner September 24, 2024 04:54
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 24, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 24, 2024

Deploying dexter with  Cloudflare Pages  Cloudflare Pages

Latest commit: e4d03cb
Status: ✅  Deploy successful!
Preview URL: https://24fef0b7.dexter-1we.pages.dev
Branch Preview URL: https://dependabot-npm-and-yarn-npm-hk7d.dexter-1we.pages.dev

View logs

@dcts
Copy link
Contributor

dcts commented Oct 4, 2024

When I test this on stokenet, I cannot place buy orders, the BUY button is disabled, even though I entered a valid amount. Can anyone reproduce this? @fliebenberg @nguvictor ?

@yuliaSharabi
Copy link
Contributor

@dcts Can you give the preview link I will test?

@yuliaSharabi
Copy link
Contributor

Link for testing
Yes, Buy or Sell button is disabled. But it's flaky. I managed twice to see it enabled and to perform Market Buy order.
TX:txid_tdx_2_1dwhew50vez3dc5p3avkwcg8mncy7h0ztxuhk2ner3zseztzen5aq3hr6q6

@yuliaSharabi
Copy link
Contributor

@dcts Any update on it?

@yuliaSharabi
Copy link
Contributor

@dcts Still same. If you wait 1-2 minutes the button eventually get enabled and you can BUY/SELL.
If again you'd adjust the number again you'd wait. Very annoying.

@dcts
Copy link
Contributor

dcts commented Nov 8, 2024

I tested critical user journeys:

  • BUY/SELL MARKET
  • cancel order

All worked well, merging this PR.

@dcts dcts merged commit 4f8ccb1 into main Nov 8, 2024
2 checks passed
@dcts dcts deleted the dependabot/npm_and_yarn/npm_and_yarn-e1825f7a49 branch November 8, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants