Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG REPORT + FIX: Selecting pairs other than DEXTR/XRD silently crashed app #608

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

dcts
Copy link
Contributor

@dcts dcts commented Nov 12, 2024

Bugreport

reported by @RenatoBro on telegram:

  • whenever the token is changed via pairSelector, the app stops working properly (silently crashes without notifying user).
  • users no longer can place orders or see the chart data

Cause

This bug was introduced with the Slider UI. Some explenations:

  • the getQuote API from alphadex API seems to throw an error when the amount is 0, but only for mainnet (not on stokenet). Just out of curiosity: Is this true/possible @fliebenberg?
  • we removed the validation tests for ZERO AMOUNT in the PR, because the slider would trigger that ERROR too often, making the UX bad. Based on that new UX with the slider, we decided to no longer throw an error if the amount is zero. Unfortunately I did not update the getQuote call.
  • once I added the validation (in the code, not user facing) back in, everything seems to be resolved.

Bounty Suggestion

MEDIUM bug, 1000 DEXTR, payed out to @RenatoBro. Reason:
"Performance decreasing bugs, UI bugs that affect/block core functionality (e.g. cannot place orders, cannot vote or similar)" -> 1000 DEXTR

Bildschirmfoto 2024-11-12 um 23 54 52

Source: https://docs.google.com/document/d/1Xh1wxLCaSX19XiP9OmMzYCg-e8V9jPk5DHPZFVGGuPM/edit?tab=t.0

@dcts dcts added the bugbounty inReview Bugbounty is in review. Once it is approved, the label should be changed to "bugbounty approved" label Nov 12, 2024
@dcts dcts requested a review from a team as a code owner November 12, 2024 22:41
@dcts dcts added the bug Something isn't working label Nov 12, 2024
@Radstakes Radstakes merged commit 8de4277 into main Nov 12, 2024
2 checks passed
@Radstakes Radstakes deleted the fix-pair-selector-issue branch November 12, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bugbounty inReview Bugbounty is in review. Once it is approved, the label should be changed to "bugbounty approved"
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants