Anna design feedback #290
Merged
Anna design feedback #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxgr-linux
requested changes
Mar 27, 2024
| @@ -23,7 +23,7 @@ const useLoginInstance = () => { | |||
| router.push({name: "UserView", params: {id: address.value}}) | |||
| } | |||
| signUpRequired().then((required) => { | |||
| console.log(required) | |||
| console.log("signUpRequired?", required) | |||
There was a problem hiding this comment.
ist ein console.log von dir, wo ich text hinzugefügt habe, damit es nicht mehr komplett random rankommt
| v-if="successScreenVisible" | ||
| class="w-[60rem] p-8 mb-20 text-white text-center text-xl font-['Roboto'] bg-pussy-red bg-opacity-70 shadow-xl shadow-black/25" | ||
| > | ||
| <div class="uppercase font-bold pt-12"> |
src/views/CardCreatorPage.vue
Outdated
| </div> | ||
|
|
||
| <!-- Card Name --> | ||
| <div | ||
| v-if="activeStep == 2" | ||
| class="flex flex-row justify-center" | ||
| > | ||
| <div class="pl-[4rem] pt-5 pb-4 h-[26.5rem]"> | ||
| <div class="pl-[0rem] pt-5 pb-4 h-[26.5rem]"> |
| @@ -207,6 +207,7 @@ const isArtist = computed(() => props.model.artist == address.value) | |||
| const state = reactive(initialState); | |||
|
|
|||
| watch(lastInputEvent, (event) => { | |||
| console.log("lastinputevent", event) | |||
| @@ -330,22 +394,22 @@ | |||
| v-model="model.FlavourText" | |||
| class="py-3 px-2 mx-3 bg-transparent text-white text-opacity-100 text-s focus:border-black border-0 border-solid focus:outline-none focus:ring-0 placeholder-white placeholder-opacity-50" | |||
| placeholder="Quote that represents this card." | |||
| maxLength="25" | |||
| maxLength="250" | |||
There was a problem hiding this comment.
Gabs nicht schon probleme mit sehr langem flavourtext?
There was a problem hiding this comment.
nö, du meinst wahrscheinlich kartentitel oder etwas was auch angezeigt wird auf der karte
There was a problem hiding this comment.
Irgendwer hat sich doch meune mal beschwehrt, dass die flovoutexts im cardview zu lang sind
src/views/CardCreatorPage.vue
Outdated
| class="flex flex-row justify-center" | ||
| > | ||
| <div class="pl-[4rem] pt-5 pb-4 h-[26.5rem]"> | ||
| <div class="pl-[0rem] pt-5 pb-4 h-[26.5rem]"> |
src/views/CardCreatorPage.vue
Outdated
| class="flex flex-row justify-center" | ||
| > | ||
| <div class="pl-[4rem] pt-5 pb-4 h-[26.5rem]"> | ||
| <div class="pl-[0rem] pt-5 pb-4 h-[26.5rem]"> |
src/views/CardCreatorPage.vue
Outdated
| @@ -510,18 +574,15 @@ | |||
| /> | |||
| </div> | |||
| <div class="text-left flex flex-col justify-between"> | |||
| <div class="pr-[4.5rem] py-5 justify-center"> | |||
| <div class="pl-10 pr-[4.0rem] py-5 justify-center"> | |||
src/views/CardCreatorPage.vue
Outdated
| class="flex flex-row justify-center" | ||
| > | ||
| <div class="pl-[4rem] pt-5 pb-4 h-[26.5rem]"> | ||
| <div class="pl-[0rem] pt-5 pb-4 h-[26.5rem]"> |
| @@ -865,10 +988,12 @@ export default { | |||
| "open", | |||
| "open", | |||
| "open", | |||
| "open", | |||
There was a problem hiding this comment.
Diesen ganzen progressbar spaß kann man doch mit EINEM enum lösen, bitte nicht liste von werten bei dem genau immer einer active ist
There was a problem hiding this comment.
3 states?
es gibt doch immer nur einen view, das activ ist, oder?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.