feat: reimpl rotary embedding for npu #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jingguo-st
commented
Sep 10, 2024
•
jingguo-st
commented
- reimpl rotary embedding with npu_rotary_mul in torch_npu
- using combined rms_norm and rotary_embedding temporarily for accuracy.
jingguo-st
force-pushed
the
fuj/fix-rotary-embedding
branch
from
cf21627
to
21fcb43
Compare
jingguo-st
force-pushed
the
fuj/fix-rotary-embedding
branch
2 times, most recently
from
9618238
to
d8f0ddc
Compare
jingguo-st
force-pushed
the
fuj/fix-rotary-embedding
branch
from
d8f0ddc
to
eb4daba
Compare
yangbofun
approved these changes
Sep 11, 2024
POI-WX
approved these changes
Sep 11, 2024
yangbofun
added a commit
that referenced
this pull request
Sep 12, 2024
This reverts commit 22bffd4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.