Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: make deeplink_ext a conventional python package #36

Merged
merged 9 commits into from
Jan 25, 2024
Merged

Conversation

lljbash
Copy link
Collaborator

@lljbash lljbash commented Jan 24, 2024

plus offering a patching mechanism to patch InternLM and lightllm

plus offering a patching mechanism to patch InternLM and lightllm
lljbash added a commit to DeepLink-org/InternLM that referenced this pull request Jan 24, 2024
lljbash added a commit to DeepLink-org/InternLM that referenced this pull request Jan 24, 2024
@lljbash lljbash requested a review from wyz5864 January 24, 2024 09:56
@wyz5864
Copy link

wyz5864 commented Jan 24, 2024

这里 加下 diopiGetLastErrorString 的结果,错误码也加一下

except AttributeError:
print(f"[deeplink_ext] op {op} is not implemented in diopi\n", end="")

for op in patch_list:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个缩进好像有问题?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还真是

@lljbash lljbash merged commit 1a9fc6d into main Jan 25, 2024
2 checks passed
lljbash added a commit to DeepLink-org/InternLM that referenced this pull request Jan 25, 2024
@lljbash lljbash deleted the llj-dev branch January 25, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants