ci(format): add run_format.sh script #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Help users to run the format locally with the same version as GitHub Actions CI. Also update the black version in the format.yml to 24.3.0.
wiryls
reviewed
Mar 29, 2024
| } | ||
|
|
||
| # format all C/C++ files in current git repository with clang-format | ||
| check_cmd_version clang-format 17.x |
There was a problem hiding this comment.
假如开发者只修改了 Python 代码但没有动过 C++，同时开发机也没有 clang 17，这种情况会不会不太方便
wiryls
approved these changes
Mar 29, 2024
wiryls
reviewed
Mar 29, 2024
|
|
||
| set -euo pipefail | ||
|
|
||
| cd "$(dirname "$0")" || exit 1 |
There was a problem hiding this comment.
能否避免修改工作目录，比如我经常在 dipu 目录跑各种脚本。运行
bash ../run_format.sh就会切到仓库根目录
fandaoyi
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help users to run the format locally with the same version as GitHub Actions CI.
Also update the black version in the format.yml to 24.3.0.