move if into TORCHCHECK

DeepLink-org · Sep 26, 2024 · 365075a · 365075a
1 parent c161068
commit 365075a
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/dipu/torch_dipu/csrc_dipu/vendor/droplet/pccl.cpp b/dipu/torch_dipu/csrc_dipu/vendor/droplet/pccl.cpp
@@ -70,19 +70,15 @@ static const std::map<pcclDataType_t, at::ScalarType> toScalarType = {
 
 at::ScalarType PcclDataTypeToScalarType(pcclDataType_t pccl_data_type) {
   auto p = toScalarType.find(pccl_data_type);
-  if (p == toScalarType.end()) {
-    TORCH_CHECK(false, "Not supported pcclDataType_t: " +
-                           std::to_string(pccl_data_type));
-  }
+  TORCH_CHECK(p != toScalarType.end(), "Not supported pcclDataType_t: " +
+                                           std::to_string(pccl_data_type));
   return p->second;
 }
 
 static const pcclComm_t kMagicComm = reinterpret_cast<pcclComm_t>(0x5043434C);
 
 void checkCommOrThrow(pcclComm_t comm) {
-  if (comm == nullptr || comm != kMagicComm) {
-    TORCH_CHECK(false, "Invalid comm.");
-  }
+  TORCH_CHECK(comm != nullptr && comm == kMagicComm, "Invalid comm.");
 }
 
 [[noreturn]] void throwNotSupportedError() {