Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass CMAKE_EXPORT_COMPILE_COMMANDS from DIPU to DIOPI #425

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Pass CMAKE_EXPORT_COMPILE_COMMANDS from DIPU to DIOPI #425

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68c3b7e
feat: keep CMAKE_EXPORT_COMPILE_COMMANDS
wiryls Nov 14, 2023
dad0172
feat: pass commands to kineto
wiryls Nov 14, 2023
1bad211
fix: add quotes to args
wiryls Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dipu/third_party/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ if (WITH_DIOPI_LIBRARY STREQUAL "INTERNAL")
-DIMPL_OPT=${DIOPI_IMPL_OPT}
-DENABLE_COVERAGE=${USE_COVERAGE}
-DCMAKE_PREFIX_PATH=${DIOPI_CMAKE_PREFIX_PATH}
-DCMAKE_EXPORT_COMPILE_COMMANDS=${CMAKE_EXPORT_COMPILE_COMMANDS}
BUILD_BYPRODUCTS "${DIOPI_LIBRARY_PATH}/libdiopi_impl.so"
INSTALL_COMMAND cmake -E echo "Skipping install step for diopi_internal.")

Expand Down Expand Up @@ -100,6 +101,7 @@ ExternalProject_Add(kineto_internal
CMAKE_ARGS "-DKINETO_BUILD_TESTS=OFF"
"-DKINETO_USE_DEVICE_ACTIVITY=ON"
"-DKINETO_COMPILED_WITH_CXX11_ABI=${DIPU_COMPILED_WITH_CXX11_ABI}"
-DCMAKE_EXPORT_COMPILE_COMMANDS=${CMAKE_EXPORT_COMPILE_COMMANDS}
BUILD_BYPRODUCTS "${KINETO_BUILD_PATH}/fmt/libfmt.a"
"${KINETO_BUILD_PATH}/libkineto.a"
INSTALL_COMMAND cmake -E echo "Skipping install step for kineto_internal."
Expand Down
Loading