Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zq/add specified autocompare #785
base: main
Are you sure you want to change the base?
Zq/add specified autocompare #785
Changes from 1 commit
60eb031
76d96f6
63a4ff7
538cf2f
5348043
6d8a8e3
4790315
ba73de3
e97db80
8e95f2f
1ba0e04
f27200b
e534ce2
f2d7ff9
5598c1b
3c63c9f
5cdba1a
9d9923e
458233c
389a267
c8dbb34
8d40cf9
d5a38d0
16585db
0a5cd89
17ce56f
5413aec
6931b62
dedb0c5
94b98f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 161 in dipu/QuickStart.md
Trailing spaces
Check failure on line 161 in dipu/QuickStart.md
Headings should be surrounded by blank lines
Check failure on line 184 in dipu/QuickStart.md
Headings should be surrounded by blank lines
Check failure on line 186 in dipu/QuickStart.md
Fenced code blocks should be surrounded by blank lines
Check failure on line 215 in dipu/QuickStart.md
Headings should be surrounded by blank lines
Check failure on line 217 in dipu/QuickStart.md
Lists should be surrounded by blank lines
Check failure on line 217 in dipu/QuickStart.md
Lists should be surrounded by blank lines
Check failure on line 218 in dipu/QuickStart.md
Fenced code blocks should be surrounded by blank lines
Check failure on line 231 in dipu/QuickStart.md
Trailing spaces
Check failure on line 232 in dipu/QuickStart.md
Lists should be surrounded by blank lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嵌套太多层了,这里的逻辑可以简化很多
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我把嵌套的if条件拆开了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
考虑到用户对正则的不熟悉,是否有必要改成 wildcard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多数场景下,算子匹配并不会用到很复杂的正则的语法,在readme里面多给几个常用的场景的示例就可以了。
但如果换成wildcard,灵活性会差很多,可能不能满足一些极端场景的需求