Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't duplicate issues when same artifact is reported again #12

Merged
merged 7 commits into from
Nov 13, 2023
Merged

fix: don't duplicate issues when same artifact is reported again #12

merged 7 commits into from
Nov 13, 2023

Conversation

srijan-deepsource
Copy link
Contributor

Changes:

  • Check the artifact result's hash before parsing. Ignore the artifact if the hash is same.
  • Raise sentry info alerts for unsanitised issues
  • fix type hints
  • add missing tests

@srijan-deepsource
fix: don't duplicate issues when same artifact is reported again
93ec696 
Calculate the result hash to figure out if an artifact is duplicate.
This allows us to skip parsing duplicate artifacts and avoid raising duplicate issues.
@srijan-deepsource
raise sentry alerts for unsanitised issues
479da75
@srijan-deepsource
fix type issues
a51eb1a
deepsource-autofix bot and others added 2 commits November 13, 2023 10:44
@deepsource-autofix
style: format code with Black and isort
d2f25eb 
This commit fixes the style issues introduced in a51eb1a according to the output
from Black and isort.

Details: #12
@srijan-deepsource
Delete .vscode/settings.json
b0776dd 
Signed-off-by: Srijan Saurav <[email protected]>
@srijan-deepsource srijan-deepsource merged commit 3ed5cbe into master Nov 13, 2023
1 check passed
@tushar-deepsource tushar-deepsource deleted the eng-383 branch November 14, 2023 07:27
vishnu-deepsource pushed a commit that referenced this pull request Nov 28, 2023
@srijan-deepsource @vishnu-deepsource
fix: don't duplicate issues when same artifact is reported again (#12)
fc7f900 
Changes:
- Check the artifact result's hash before parsing. Ignore the artifact
if the hash is same.
  - Raise sentry info alerts for unsanitised issues
  - fix type hints
  - add missing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tushar-deepsource tushar-deepsource tushar-deepsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srijan-deepsource @tushar-deepsource