feat: margin zero #12971

0xradishmz · 2025-01-05T17:53:29Z

NOTE

Please enable "Allow edits by maintainers" while putting up the PR.

If you would like to add a volume adapter please submit the PR here.

If you would like to add a liquidations adapter, please refer to this readme document for details.

Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.
Sorry, We no longer accept fetch adapter for new projects, we prefer the tvl to computed from blockchain data, if you have trouble with creating a the adapter, please hop onto our discord, we are happy to assist you.
Please fill the form below only if the PR is for listing a new protocol else it can be ignored/replaced with reason/details about the PR
For updating listing info It is a different repo, you can find your listing in this file: https://github.com/DefiLlama/defillama-server/blob/master/defi/src/protocols/data2.ts, you can edit it there and put up a PR
Do not edit/push package-lock.json file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CI
No need to go to our discord and announce that you've created a PR, we monitor all PRs and will review it asap

Name (to be shown on DefiLlama):

Margin Zero

Logo (High resolution, will be shown with rounded borders):

Current TVL:

Treasury Addresses (if the protocol has treasury)

Chain:

Sonic (cross chain soon)

Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)

Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)

Short Description (to be shown on DefiLlama):

MarginZero is an omni-chain, oracle-less and permission-less options & protected perpetual protocol

Token address and ticker if any:

Category (full list at https://defillama.com/categories) *Please choose only one:

Options

Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):

Implementation Details: Briefly describe how the oracle is integrated into your project:

Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:

forkedFrom (Does your project originate from another project):

methodology (what is being counted as tvl, how is tvl being calculated):

TVL is the total amount of tokens deposited in DEX's through Margin Zero's handler contracts.

Github org/user (Optional, if your code is open source, we can track activity):

https://github.com/marginzero-xyz

llamabutler · 2025-01-05T17:53:53Z

The adapter at projects/margin-zero exports TVL:

sonic                     21.83 k

total                    21.83 k

g1nt0ki

.

g1nt0ki · 2025-01-06T10:20:35Z

projects/margin-zero/index.js

+const chainConfig = {
+  146: {
+    chainName: "sonic",
+    subgraph: "https://api.goldsky.com/api/public/project_cm58q8wq01kbk01ts09lc52kp/subgraphs/mz-subgraph/main/gn"


is there any way to get tokenIds of the uni v3 positions? we have helper code to unwrap and pull tvl from it, would simplify this adapter code

Our contracts do not deposit through Nft position manager contract but rather directly into the pool, so we don't have the v3 tokenIds

not uni v3, but your position manager does?

https://sonicscan.org/tx/0x1ad74b93afde626b5c49174949efdc5e1cec8d5740e2fc27db9a0b19128c318e#eventlog

then, we can fetch value onchain using WagmiV3Handler ?

https://sonicscan.org/address/0xe7e225194e81729b27e8fa5c1ebd801d502c016b#readContract

g1nt0ki · 2025-01-06T10:21:38Z

projects/margin-zero/index.js

+}
+
+function LiquidityRangesQuery(first, skip) {
+  return `{ liquidityRanges(first: ${first}, skip: ${skip}) {pool liquidity tickLower tickUpper }}`


I think you should add a liquidity_gt: 100 to filter out expired positions

I'm sorry, what do you mean by expired positions?

@0xradishmz when liquidity is withdrawn, I saw a few positions with 0 liquidity

@0xradishmz when liquidity is withdrawn, I saw a few positions with 0 liquidity

sounds good, thanks for clarification

g1nt0ki · 2025-01-06T10:21:59Z

projects/margin-zero/index.js

+
+
+async function tvl(sdk) {
+  if (sdk.api.chainId && chainConfig[sdk.api.chainId]) {


dont think this check is needed

g1nt0ki · 2025-01-06T10:22:27Z

projects/margin-zero/index.js

+}
+
+
+async function tvl(sdk) {


change sdk -> api

g1nt0ki · 2025-01-06T10:27:44Z

projects/margin-zero/index.js

+
+    let counter = 0;
+    while (true) {
+      const { liquidityRanges } = await cachedGraphQuery('marign-zero/tvl', subgraphUrl, LiquidityRangesQuery(1000, 1000 * counter))


you should use fetchById here (also, update the query), like https://github.com/0xradishmz/DefiLlama-Adapters/blob/pr/0xradishmz/12971/projects/panoptic/index.js#L63

noticed that panoptic & this adapter have the same bug, if we use cached graph data, we will end up with incorrect liquidity data & wrong tvl, but using tokenIds fixing it (so we fetch liquidity on chain)

llamabutler · 2025-01-06T18:45:51Z

The adapter at projects/margin-zero exports TVL:

sonic                     21.39 k

total                    21.39 k

llamabutler · 2025-01-08T17:51:34Z

The adapter at projects/margin-zero exports TVL:

sonic                     17.37 k

total                    17.37 k

llamabutler · 2025-01-08T17:53:11Z

The adapter at projects/margin-zero exports TVL:

sonic                     17.37 k

total                    17.37 k

llamabutler · 2025-01-08T17:53:53Z

The adapter at projects/margin-zero exports TVL:

sonic                     17.38 k

total                    17.38 k

llamabutler · 2025-01-08T17:55:02Z

The adapter at projects/margin-zero exports TVL:

sonic                     17.28 k

total                    17.28 k

llamabutler · 2025-01-08T17:55:49Z

The adapter at projects/margin-zero exports TVL:

sonic                     17.28 k

total                    17.28 k

g1nt0ki · 2025-01-09T23:33:21Z

@0xradishmz thanks for the PR

llamabutler · 2025-01-09T23:33:25Z

The adapter at projects/margin-zero exports TVL:

sonic                     17.56 k

total                    17.56 k

feat: margin zero tvl

be664a9

g1nt0ki self-assigned this Jan 6, 2025

g1nt0ki requested changes Jan 6, 2025

View reviewed changes

feat: feedback changes

6e6bbe7

feat: feedback changes

6fa79cd

0xradishmz requested a review from g1nt0ki January 8, 2025 17:51

chore: remove unused var

4fff8b0

chore: formatting

09b3b6c

chore: formatting

dc6bf05

chore: remove unused query var

18e13b0

minor fix

a70a814

g1nt0ki merged commit 007159c into DefiLlama:main Jan 9, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: margin zero #12971

feat: margin zero #12971

0xradishmz commented Jan 5, 2025 •

edited

Loading

llamabutler commented Jan 5, 2025

g1nt0ki left a comment

g1nt0ki Jan 6, 2025

0xradishmz Jan 6, 2025

g1nt0ki Jan 8, 2025

g1nt0ki Jan 6, 2025

0xradishmz Jan 6, 2025

g1nt0ki Jan 8, 2025

0xradishmz Jan 8, 2025

g1nt0ki Jan 6, 2025

g1nt0ki Jan 6, 2025

g1nt0ki Jan 6, 2025

llamabutler commented Jan 6, 2025

llamabutler commented Jan 8, 2025

llamabutler commented Jan 8, 2025

llamabutler commented Jan 8, 2025

llamabutler commented Jan 8, 2025

llamabutler commented Jan 8, 2025

g1nt0ki commented Jan 9, 2025

llamabutler commented Jan 9, 2025



		async function tvl(sdk) {
		if (sdk.api.chainId && chainConfig[sdk.api.chainId]) {

feat: margin zero #12971

feat: margin zero #12971

Conversation

0xradishmz commented Jan 5, 2025 • edited Loading

Please enable "Allow edits by maintainers" while putting up the PR.

Name (to be shown on DefiLlama):

Twitter Link:

List of audit links if any:

Website Link:

Logo (High resolution, will be shown with rounded borders):

Current TVL:

Treasury Addresses (if the protocol has treasury)

Chain:

Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)

Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)

Short Description (to be shown on DefiLlama):

Token address and ticker if any:

Category (full list at https://defillama.com/categories) *Please choose only one:

Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):

Implementation Details: Briefly describe how the oracle is integrated into your project:

Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:

forkedFrom (Does your project originate from another project):

methodology (what is being counted as tvl, how is tvl being calculated):

Github org/user (Optional, if your code is open source, we can track activity):

llamabutler commented Jan 5, 2025

g1nt0ki left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

llamabutler commented Jan 6, 2025

llamabutler commented Jan 8, 2025

llamabutler commented Jan 8, 2025

llamabutler commented Jan 8, 2025

llamabutler commented Jan 8, 2025

llamabutler commented Jan 8, 2025

g1nt0ki commented Jan 9, 2025

llamabutler commented Jan 9, 2025

0xradishmz commented Jan 5, 2025 •

edited

Loading