-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security(gomod): 🛡️ patch 🛡️ vulnerability [unknown] #176
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
- Coverage 32.61% 25.29% -7.32%
==========================================
Files 80 79 -1
Lines 10855 11088 +233
==========================================
- Hits 3540 2805 -735
- Misses 7027 8012 +985
+ Partials 288 271 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
425b09f
to
0c7710c
Compare
0c7710c
to
4df9846
Compare
Pull request was closed
d4c33b0
to
4df9846
Compare
4df9846
to
dd0f3cb
Compare
ℹ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
This PR contains the following updates:
v4.5.0
->v4.5.1
v0.21.0
->v0.27.0
GitHub Vulnerability Alerts
CVE-2024-51744
Summary
Unclear documentation of the error behavior in
ParseWithClaims
can lead to situation where users are potentially not checking errors in the way they should be. Especially, if a token is both expired and invalid, the errors returned byParseWithClaims
return both error codes. If users only check for thejwt.ErrTokenExpired
usingerror.Is
, they will ignore the embeddedjwt.ErrTokenSignatureInvalid
and thus potentially accept invalid tokens.Fix
We have back-ported the error handling logic from the
v5
branch to thev4
branch. In this logic, theParseWithClaims
function will immediately return in "dangerous" situations (e.g., an invalid signature), limiting the combined errors only to situations where the signature is valid, but further validation failed (e.g., if the signature is valid, but is expired AND has the wrong audience). This fix is part of the 4.5.1 release.Workaround
We are aware that this changes the behaviour of an established function and is not 100 % backwards compatible, so updating to 4.5.1 might break your code. In case you cannot update to 4.5.0, please make sure that you are properly checking for all errors ("dangerous" ones first), so that you are not running in the case detailed above.
Improper error handling in ParseWithClaims and bad documentation may cause dangerous situations in github.com/golang-jwt/jwt
CVE-2024-51744 / GHSA-29wx-vh33-7x7r / GO-2024-3250
More information
Details
Improper error handling in ParseWithClaims and bad documentation may cause dangerous situations in github.com/golang-jwt/jwt
Severity
Unknown
References
This data is provided by OSV and the Go Vulnerability Database (CC-BY 4.0).
Bad documentation of error handling in ParseWithClaims can lead to potentially dangerous situations
CVE-2024-51744 / GHSA-29wx-vh33-7x7r / GO-2024-3250
More information
Details
Summary
Unclear documentation of the error behavior in
ParseWithClaims
can lead to situation where users are potentially not checking errors in the way they should be. Especially, if a token is both expired and invalid, the errors returned byParseWithClaims
return both error codes. If users only check for thejwt.ErrTokenExpired
usingerror.Is
, they will ignore the embeddedjwt.ErrTokenSignatureInvalid
and thus potentially accept invalid tokens.Fix
We have back-ported the error handling logic from the
v5
branch to thev4
branch. In this logic, theParseWithClaims
function will immediately return in "dangerous" situations (e.g., an invalid signature), limiting the combined errors only to situations where the signature is valid, but further validation failed (e.g., if the signature is valid, but is expired AND has the wrong audience). This fix is part of the 4.5.1 release.Workaround
We are aware that this changes the behaviour of an established function and is not 100 % backwards compatible, so updating to 4.5.1 might break your code. In case you cannot update to 4.5.0, please make sure that you are properly checking for all errors ("dangerous" ones first), so that you are not running in the case detailed above.
Severity
CVSS:3.1/AV:N/AC:H/PR:N/UI:R/S:U/C:L/I:N/A:N
References
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Unexpected memory consumption during token parsing in golang.org/x/oauth2
CVE-2025-22868 / GO-2025-3488
More information
Details
An attacker can pass a malicious malformed token which causes unexpected memory to be consumed during parsing.
Severity
Unknown
References
This data is provided by OSV and the Go Vulnerability Database (CC-BY 4.0).
Release Notes
golang-jwt/jwt (github.com/golang-jwt/jwt/v4)
v4.5.1
Compare Source
Security
Unclear documentation of the error behavior in
ParseWithClaims
in <= 4.5.0 could lead to situation where users are potentially not checking errors in the way they should be. Especially, if a token is both expired and invalid, the errors returned byParseWithClaims
return both error codes. If users only check for thejwt.ErrTokenExpired
usingerror.Is
, they will ignore the embeddedjwt.ErrTokenSignatureInvalid
and thus potentially accept invalid tokens.This issue was documented in GHSA-29wx-vh33-7x7r and fixed in this release.
Note:
v5
was not affected by this issue. So upgrading to this release version is also recommended.What's Changed
ParseWithClaims
fromv5
branch. This fixes GHSA-29wx-vh33-7x7r.Full Changelog: golang-jwt/jwt@v4.5.0...v4.5.1
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.