Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security(maven): πŸ›‘οΈ major build to v7 #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 31, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
net.sourceforge.pmd:pmd-core (source) 6.55.0 -> 7.10.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2025-23215

Summary

While rebuilding PMD Designer for Reproducible Builds and digging into issues, I found out that passphrase for gpg.keyname=0xD0BF1D737C9A1C22 is included in jar published to Maven Central.

Details

See https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/net/sourceforge/pmd/pmd-designer/README.md

I removed 2 lines from https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/net/sourceforge/pmd/pmd-designer/pmd-designer-7.0.0.diffoscope but real content is:

β”œβ”€β”€ net/sourceforge/pmd/util/fxdesigner/designer.properties
β”‚ @​@​ -1,14 +1,12 @​@​
β”‚  #Properties
β”‚  checkstyle.plugin.version=3.3.1
β”‚  checkstyle.version=10.14.0
β”‚ -gpg.keyname=0xD0BF1D737C9A1C22
β”‚ -gpg.passphrase=evicx0nuPfvSVhVyeXpw
β”‚  jar.plugin.version=3.3.0
β”‚ -java.version=11.0.22
β”‚ +java.version=11.0.25
β”‚  javadoc.plugin.version=3.6.3
β”‚  jflex-output=/home/runner/work/pmd-designer/pmd-designer/target/generated-sources/jflex
β”‚  junit5.version=5.8.2
β”‚  kotest.version=5.5.5
β”‚  kotlin.version=1.7.20
β”‚  local.lib.repo=/home/runner/work/pmd-designer/pmd-designer/lib/mvn-repo
β”‚  openjfx.scope=provided

PoC

./rebuild.sh content/net/sourceforge/pmd/pmd-designer/pmd-designer-7.0.0.buildspec

Impact

After further analysis, the passphrase of the following two keys have been compromised:

  1. 94A5 2756 9CAF 7A47 AFCA BDE4 86D3 7ECA 8C2E 4C5B: PMD Designer (Release Signing Key) [email protected]
    This key has been used since 2019 with the release of net.sourceforge.pmd:pmd-ui:6.14.0.
    The following versions are signed with the same key: 6.16.0, 6.17.0, 6.19.0.
  2. EBB2 41A5 45CB 17C8 7FAC B2EB D0BF 1D73 7C9A 1C22: PMD Release Signing Key [email protected]
    This key has been used since 2020 with the release of net.sourceforge.pmd:pmd-ui:6.21.0
    and all the other modules of PMD such as net.sourceforge.pmd:pmd-core:6.21.0.
    This key has also been used for PMD 7, for the designer, e.g. net.sourceforge.pmd:pmd-designer:7.0.0
    and net.sourceforge.pmd:pmd-core:7.0.0.
    The versions between 6.21.0 and 7.9.0 are signed with this key.
    Additionally the key has been used to sign the last release of PMD Eclipse Plugin 7.9.0.v20241227-1626-r.

The keys have been used exclusively for signing artifacts that we published to Maven Central under group id net.sourceforge.pmd and once for our pmd-eclipse-plugin. The private key itself is not known to have been compromised itself, but given its passphrase is, it must also be considered potentially compromised.

As a mitigation, both compromised keys have been revoked so that no future use of the keys are possible.
For future releases of PMD, PMD Designer and PMD Eclipse Plugin we use a new release signing key:
2EFA 55D0 785C 31F9 56F2 F87E A0B5 CA1A 4E08 6838 (PMD Release Signing Key [email protected]).

Note, that the published artifacts in Maven Central under the group id net.sourceforge.pmd are not
compromised and the signatures are valid. No other past usages of the private key is known to the project
and no future use is possible due to the revocation. If anybody finds a past abuse of the private key,
please share with us.

Note, the module net.sourceforge.pmd:pmd-ui has been renamed to net.sourceforge.pmd:pmd-designer since PMD 7, so there won't be a fixed version for pmd-ui.

Fixes

References


PMD Designer's release key passphrase (GPG) available on Maven Central in cleartext

CVE-2025-23215 / GHSA-88m4-h43f-wx84

More information

Details

Summary

While rebuilding PMD Designer for Reproducible Builds and digging into issues, I found out that passphrase for gpg.keyname=0xD0BF1D737C9A1C22 is included in jar published to Maven Central.

Details

See https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/net/sourceforge/pmd/pmd-designer/README.md

I removed 2 lines from https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/net/sourceforge/pmd/pmd-designer/pmd-designer-7.0.0.diffoscope but real content is:

β”œβ”€β”€ net/sourceforge/pmd/util/fxdesigner/designer.properties
β”‚ @​@​ -1,14 +1,12 @​@​
β”‚  #Properties
β”‚  checkstyle.plugin.version=3.3.1
β”‚  checkstyle.version=10.14.0
β”‚ -gpg.keyname=0xD0BF1D737C9A1C22
β”‚ -gpg.passphrase=evicx0nuPfvSVhVyeXpw
β”‚  jar.plugin.version=3.3.0
β”‚ -java.version=11.0.22
β”‚ +java.version=11.0.25
β”‚  javadoc.plugin.version=3.6.3
β”‚  jflex-output=/home/runner/work/pmd-designer/pmd-designer/target/generated-sources/jflex
β”‚  junit5.version=5.8.2
β”‚  kotest.version=5.5.5
β”‚  kotlin.version=1.7.20
β”‚  local.lib.repo=/home/runner/work/pmd-designer/pmd-designer/lib/mvn-repo
β”‚  openjfx.scope=provided
PoC
./rebuild.sh content/net/sourceforge/pmd/pmd-designer/pmd-designer-7.0.0.buildspec
Impact

After further analysis, the passphrase of the following two keys have been compromised:

  1. 94A5 2756 9CAF 7A47 AFCA BDE4 86D3 7ECA 8C2E 4C5B: PMD Designer (Release Signing Key) [email protected]
    This key has been used since 2019 with the release of net.sourceforge.pmd:pmd-ui:6.14.0.
    The following versions are signed with the same key: 6.16.0, 6.17.0, 6.19.0.
  2. EBB2 41A5 45CB 17C8 7FAC B2EB D0BF 1D73 7C9A 1C22: PMD Release Signing Key [email protected]
    This key has been used since 2020 with the release of net.sourceforge.pmd:pmd-ui:6.21.0
    and all the other modules of PMD such as net.sourceforge.pmd:pmd-core:6.21.0.
    This key has also been used for PMD 7, for the designer, e.g. net.sourceforge.pmd:pmd-designer:7.0.0
    and net.sourceforge.pmd:pmd-core:7.0.0.
    The versions between 6.21.0 and 7.9.0 are signed with this key.
    Additionally the key has been used to sign the last release of PMD Eclipse Plugin 7.9.0.v20241227-1626-r.

The keys have been used exclusively for signing artifacts that we published to Maven Central under group id net.sourceforge.pmd and once for our pmd-eclipse-plugin. The private key itself is not known to have been compromised itself, but given its passphrase is, it must also be considered potentially compromised.

As a mitigation, both compromised keys have been revoked so that no future use of the keys are possible.
For future releases of PMD, PMD Designer and PMD Eclipse Plugin we use a new release signing key:
2EFA 55D0 785C 31F9 56F2 F87E A0B5 CA1A 4E08 6838 (PMD Release Signing Key [email protected]).

Note, that the published artifacts in Maven Central under the group id net.sourceforge.pmd are not
compromised and the signatures are valid. No other past usages of the private key is known to the project
and no future use is possible due to the revocation. If anybody finds a past abuse of the private key,
please share with us.

Note, the module net.sourceforge.pmd:pmd-ui has been renamed to net.sourceforge.pmd:pmd-designer since PMD 7, so there won't be a fixed version for pmd-ui.

Fixes
References

Severity

  • CVSS Score: Unknown
  • Vector String: CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N/MVC:N/MVI:N/MVA:N/U:Clear

References

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).


Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

β™» Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

πŸ‘» Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner January 31, 2025 20:41
@renovate renovate bot requested a review from pacificcode January 31, 2025 20:41
@renovate renovate bot enabled auto-merge (squash) January 31, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants