Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even more packages + Mail localization #2384

Closed

Conversation

Monotheonist
Copy link
Contributor

@Monotheonist Monotheonist commented Dec 7, 2024

About the PR

Adds:

  • Scarves and box mail that someone made a PR for and then instantly closed, so it never got in. Scarves has a small chance for syndicate scarves and a very very low chance for a CC scarf.
  • Roboticist mail for Epistemics (ships 1 robot part and a battery.)

Tweaks:

  • Moved the foam sabre into the general sword mail with the same probability as every other fake weapon in there.
  • Localizes the frontier mail by making paper_mail.ftl and then doing a shitload of copy-paste action (the entire thing looks like hell, christ.)
  • Tweaks comments in various files because there's just random spaces n' stuff.

Why / Balance

It's just some extra stuff to add to the amazing bloat that the mail is, and also at the same time debloats it.

Technical details

Technical changes are just YAML, random removal of space, reformatting of comments, and locstrings. If you want specifics look at the files changed.

Media

Not necessary. It's pretty small.

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Because of the way this PR is, pulling it to any other downstream may be a little fucky because it's two things (mail tweaks + new mail) and I'm going to apologize for that here, otherwise, sorry nothing.
Also the mail locale! IF IT BREAKS AND DOES NOT FORMAT IMMEDIATELY MAKE AN ISSUE AND I WILL TRY TO FIX IT. Style tags in FTL files are fucky, apparently.

Changelog

🆑

  • add: Adds a few more parcels into the mail pool.

@Monotheonist Monotheonist requested a review from a team as a code owner December 7, 2024 04:50
@github-actions github-actions bot added size/L 256-1023 lines Changes: YML Changes any yml files Changes: Localization Changes any ftl files S: Needs Review and removed size/L 256-1023 lines labels Dec 7, 2024
@Monotheonist
Copy link
Contributor Author

Free from the clutches of the linter, finally, christ.

@deltanedas deltanedas requested a review from a team as a code owner December 17, 2024 04:52
@Monotheonist Monotheonist closed this by deleting the head repository Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants