Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Improvements to NanoChat #2922

Merged
merged 15 commits into from
Feb 23, 2025
Merged

Various Improvements to NanoChat #2922

merged 15 commits into from
Feb 23, 2025

Conversation

Toby222
Copy link
Contributor

@Toby222 Toby222 commented Feb 7, 2025 •
edited
Loading

About the PR

  • Better notifications
    • Notifications get sent without NanoChat open
    • Notifications get sent when you're on another chat
    • Notifications include sender's job
    • Muting specific contacts
  • Allow editing contacts
  • Better notifications
  • Editing contacts
  • Make NanoChat UI nicer to use
    • Enter to send
    • Tab to switch fields
    • Keybinds for switching channel

Why / Balance

NanoChat as-is is still not very nice to use. These changes should ideally make it a good alternative communication method to trying to call out people in common.

Technical details

Some ported from:

Media

2025-02-08.01-36-20.mp4
2025-02-08.01-43-33.mp4
2025-02-08.01-48-51.mp4

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

  • Several constants relating to NanoChat were moved, removed, or renamed
  • The NanoChatMessage enum got a new member

Changelog
🆑

  • add: NanoChat message notifications will now show you the job title of the sender alongside their name.
  • add: NanoChat now lets you edit contacts.
  • add: Enter and tab now work in NanoChat and its popup
  • add: Keybinds for switching chats in NanoChat
  • tweak: The character limits for names and job titles are not consistent between ID cards and NanoChat
  • tweak: NanoChat chat list names/titles and notification titles that are too long will be shortened, indicated with "..." at the end.
  • tweak: Changed the layout of NanoChat buttons
  • fix: NanoChat will now send a new message notification no matter what, so long as you're not currently looking at it.
  • fix: Fixed a issue where users could potentially send NanoChat messages longer than the maximum allowed message length.
  • fix: Fixed being able to create a new chat when you haven't typed in 4 digits in the number field.

@github-actions github-actions bot added size/L 256-1023 lines Changes: UI Changes: C# Changes any cs files Changes: Localization Changes any ftl files labels Feb 7, 2025
dvir001
dvir001 suggested changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move edit.svg.png under _DV Folders.

@sleepyyapril
Copy link
Contributor

merge is from wizden, i made it, hi

@Toby222
Copy link
Contributor Author

Toby222 commented Feb 7, 2025

merge is from wizden, i made it, hi

I tried to look there but the relevant commits are for NanoChat which isn't on wizden, if I'm not mistaken

@sleepyyapril
Copy link
Contributor

merge is from wizden, i made it, hi

I tried to look there but the relevant commits are for NanoChat which isn't on wizden, if I'm not mistaken

I made them in the PR, silly of me I know

@github-actions github-actions bot added the Changes: YML Changes any yml files label Feb 7, 2025
@Toby222 Toby222 changed the title Port improvements to NanoChat from Einstein-Engines and Goob-Station Various Improvements to NanoChat Feb 7, 2025
@Toby222 Toby222 marked this pull request as ready for review February 8, 2025 00:52
@Toby222 Toby222 requested review from a team as code owners February 8, 2025 00:52
Lyndomen
Lyndomen previously approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing QOL, huge +1

@Toby222 Toby222 requested a review from dvir001 February 10, 2025 18:06
@honeyed-lemons honeyed-lemons mentioned this pull request Feb 15, 2025
Merged
deltanedas
deltanedas requested changes Feb 23, 2025
View reviewed changes
@Toby222
Copy link
Contributor Author

Toby222 commented Feb 23, 2025

Done

@Toby222 Toby222 requested a review from deltanedas February 23, 2025 13:21
deltanedas
deltanedas requested changes Feb 23, 2025
View reviewed changes
deltanedas
deltanedas previously approved these changes Feb 23, 2025
View reviewed changes
@deltanedas deltanedas enabled auto-merge (squash) February 23, 2025 15:26
auto-merge was automatically disabled February 23, 2025 15:46

Head branch was pushed to by a user without write access

@Toby222
Copy link
Contributor Author

Toby222 commented Feb 23, 2025

NOW we're done 😭

@deltanedas deltanedas enabled auto-merge (squash) February 23, 2025 15:53
@deltanedas deltanedas merged commit 4ecf2aa into DeltaV-Station:master Feb 23, 2025
26 checks passed
@Toby222 Toby222 deleted the nanochat-improvements branch February 23, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltanedas deltanedas deltanedas approved these changes

@Lyndomen Lyndomen Lyndomen left review comments

@dvir001 dvir001 Awaiting requested review from dvir001

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Toby222 @sleepyyapril @deltanedas @dvir001 @Lyndomen @honeyed-lemons