Fix minor issues Dommel workflow (#199)

Co-authored-by: Daniel Tollenaar <[email protected]>
Deltares · Dec 20, 2024 · 8769b49 · 8769b49
1 parent c2cc6ae
commit 8769b49
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/notebooks/de_dommel/01_fix_model_network.py b/notebooks/de_dommel/01_fix_model_network.py
@@ -9,10 +9,9 @@
 
 cloud = CloudStorage()
 
-authority = "BrabantseDelta"
-short_name = "wbd"
+authority = "DeDommel"
 
-ribasim_toml = cloud.joinpath(authority, "modellen", f"{authority}_2024_6_3", f"{short_name}.toml")
+ribasim_toml = cloud.joinpath(authority, "modellen", f"{authority}_2024_6_3", "model.toml")
 
 
 basin_data = [
@@ -205,7 +204,7 @@
 for node_id in df.from_node_id:
     model.update_node(node_id, "Outlet", [outlet.Static(flow_rate=[100])])
 
-# # see: https://github.com/Deltares/Ribasim-NL/issues/132
+# see: https://github.com/Deltares/Ribasim-NL/issues/132
 model.basin.area.df.loc[model.basin.area.df.duplicated("node_id"), ["node_id"]] = -1
 model.basin.area.df.reset_index(drop=True, inplace=True)
 model.basin.area.df.index.name = "fid"

diff --git a/notebooks/de_dommel/02_fix_edges.py b/notebooks/de_dommel/02_fix_edges.py
@@ -56,8 +56,8 @@
         data += [row]
         continue
 
-gpd.GeoDataFrame(data, crs=28992).to_file("rare_edges.gpkg")
+out_dir = cloud.joinpath("DeDommel", "modellen", "DeDommel_fix_edges")
+gpd.GeoDataFrame(data, crs=28992).to_file(out_dir / "rare_edges.gpkg")
 
 # %% write model
-ribasim_toml = cloud.joinpath("DeDommel", "modellen", "DeDommel_fix_edges", "model.toml")
-model.write(ribasim_toml)
+model.write(out_dir / "model.toml")
diff --git a/notebooks/de_dommel/03_fix_basin_area.py b/notebooks/de_dommel/03_fix_basin_area.py
@@ -12,7 +12,7 @@
 ribasim_toml = cloud.joinpath("DeDommel", "modellen", "DeDommel_fix_edges", "model.toml")
 model = Model.read(ribasim_toml)
 
-
+# TODO file not in the cloud
 area_gdf = gpd.read_file(cloud.joinpath("DeDommel", "verwerkt", "watervlakken", "LWW_2023_A_water_vlak_V.shp"))