Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize nzv #238

Merged
merged 11 commits into from
Jan 27, 2025
Merged

Parameterize nzv #238

merged 11 commits into from
Jan 27, 2025

Conversation

DanielTollenaar
Copy link
Collaborator

@DanielTollenaar DanielTollenaar requested a review from visr January 24, 2025 10:24
visr
visr approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the parametrized model runs in 17 seconds for a year.

@DanielTollenaar DanielTollenaar marked this pull request as ready for review January 27, 2025 09:34
@visr visr merged commit 02bc1af into main Jan 27, 2025
4 checks passed
@visr visr deleted the parameterize_nzv branch January 27, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielTollenaar @visr