opt in to extrapolation for rating curves on DataInterpolations 4.4 (#…

…677) Originally made in #663 as commit 959075f. But since it fixes breakage, best to get it on main as soon as possible.
Deltares · Oct 18, 2023 · 35320c0 · 35320c0
1 parent 5b6232a
commit 35320c0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/core/Project.toml b/core/Project.toml
@@ -43,7 +43,7 @@ ComponentArrays = "0.13.14, 0.14, 0.15"
 Configurations = "0.17"
 DBInterface = "2.4"
 DataFrames = "1.4"
-DataInterpolations = "3.7, 4"
+DataInterpolations = "4.4"
 DataStructures = "0.18"
 Dictionaries = "0.3.25"
 DiffEqCallbacks = "2.29.1"

diff --git a/core/src/bmi.jl b/core/src/bmi.jl
@@ -517,7 +517,7 @@ function update_tabulated_rating_curve!(integrator)::Nothing
         level = [row.level for row in group]
         discharge = [row.discharge for row in group]
         i = searchsortedfirst(node_id, id)
-        tables[i] = LinearInterpolation(discharge, level)
+        tables[i] = LinearInterpolation(discharge, level; extrapolate = true)
     end
     return nothing
 end

diff --git a/core/src/utils.jl b/core/src/utils.jl
@@ -294,7 +294,7 @@ function qh_interpolation(
     level::AbstractVector,
     discharge::AbstractVector,
 )::Tuple{LinearInterpolation, Bool}
-    return LinearInterpolation(discharge, level), allunique(level)
+    return LinearInterpolation(discharge, level; extrapolate = true), allunique(level)
 end
 
 """