Skip to content

Commit

Permalink
Stop running CompatHelper on root project again (#1063)
Browse files Browse the repository at this point in the history
In #1021 I enabled to run CompatHelper on the root project, but seeing
the flood of PRs this morning and thinking about it some more, I think
this was a mistake. We should close all those PRs.

Compat is needed in core for all dependencies. For other dependencies,
in principle we shouldn't declare compat, since we use a Manifest
anyway. This is similar to the way we allow any version in pixi.toml,
and the monthly pixi.lock update also brings in possibly breaking
changes that we can then evaluate.

We could have compat entries in the root project. Those makes sense if
we are not compatible with newer breaking releases to hold it back. This
way the manifest update will not bring in this incompatible release. We
should not forget about these, so ideally we have an issue labeled
`tech-debt` for those.
  • Loading branch information
visr authored Feb 2, 2024
1 parent 70b2348 commit 7d472b7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 26 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/core_compat_helper.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,7 @@ jobs:
- name: "Run CompatHelper"
run: |
import CompatHelper
CompatHelper.main(; subdirs=[
".",
"core",
])
CompatHelper.main(; subdirs=["core"])
shell: julia --color=yes {0}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
22 changes: 0 additions & 22 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -55,25 +55,3 @@ TestEnv = "1e6cf692-eddd-4d53-88a5-2d735e33781b"
TimeZones = "f269a46b-ccf7-5d73-abea-4c690281aa53"
TimerOutputs = "a759f4b9-e2f1-59dc-863e-4aeb61b1ea8f"
TranscodingStreams = "3bb67fe8-82b1-5028-8e26-92a6c54297fa"

[compat]
Artifacts = "<0.0.1,1"
BasicModelInterface = "0.1"
Configurations = "0.17"
DataFrames = "1"
Dates = "<0.0.1,1"
Documenter = "0.27,1"
DocumenterMarkdown = "0.2"
IJulia = "1"
InteractiveUtils = "<0.0.1,1"
JSON3 = "1.12"
Legolas = "0.5"
LibGit2 = "<0.0.1,1"
Logging = "<0.0.1,1"
MarkdownTables = "1"
OrderedCollections = "1.6"
PackageCompiler = "2"
TOML = "<0.0.1,1"
TerminalLoggers = "0.1.7"
TimeZones = "=1.14.0, 1"
julia = "1.10"

0 comments on commit 7d472b7

Please sign in to comment.