Skip to content

Commit

Permalink
Switch to Julia 1.10-rc1 (#738)
Browse files Browse the repository at this point in the history
Release notes here:
https://github.com/JuliaLang/julia/blob/v1.10.0-rc1/NEWS.md

Since at this point we don't care about supporting multiple julia
versions, I updated everything to 1.10.

Marking as a draft since:
- [x] Julia 1.10-rc1 needs to be installed on TeamCity
- [x] `%env.JULIA_1_10%` needs to be added on TeamCity to point to that
install (this PR already attempts to use `JULIA_1_10`)

Main reasons I'm excited about 1.10 for Ribasim; mostly for developer
experience:
- Less latency
- Better syntax errors
- Shorter stacktraces

If people want we can wait for the final release, though its good to
start kicking the 1.10 tires at least.

---------

Co-authored-by: Hofer-Julian <[email protected]>
  • Loading branch information
visr and Hofer-Julian authored Nov 10, 2023
1 parent 21af0f5 commit 8e67335
Show file tree
Hide file tree
Showing 10 changed files with 210 additions and 59 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/core_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
fail-fast: false
matrix:
julia_version:
- "1.9"
- "~1.10.0-0"
os:
- ubuntu-latest
- macOS-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
matrix:
julia_version:
- "1.9"
- "~1.10.0-0"
arch:
- x64
steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
<option name="executionTimeoutMin" value="120" />
</options>
<parameters>
<param name="conda_env_path" value="%system.teamcity.build.checkoutDir%/env_build_ribasim_cli" />
<param name="julia" value="%env.JULIA_1_9%" />
<param name="julia_dir" value="%env.JULIA_DIR_1_10%" />
</parameters>
<build-runners>
<runner id="RUNNER_2418" name="Set up pixi" type="simpleRunner">
Expand All @@ -23,8 +22,8 @@
</runner>
<runner id="RUNNER_2420" name="Build binary" type="simpleRunner">
<parameters>
<param name="script.content"><![CDATA[set Path=%env.JULIA_DIR_1_9%;%env.Path%
pixi run build-ribasim-cli]]></param>
<param name="script.content"><![CDATA[set Path=%julia_dir%;%env.Path%
pixi run build-ribasim-cli]]></param>
<param name="teamcity.build.workingDir" value="ribasim" />
<param name="teamcity.step.mode" value="default" />
<param name="use.custom.script" value="true" />
Expand Down Expand Up @@ -91,4 +90,3 @@ pixi run build-ribasim-cli]]></param>
<cleanup />
</settings>
</build-type>

Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,9 @@
<setting-ref ref="RQ_271" />
</disabled-settings>
<parameters>
<param name="conda_env_path" value="%system.teamcity.build.checkoutDir%/env_build_libribasim" />
<param name="julia" value="%env.JULIA_1_9%" />
<param name="julia_dir" value="%env.JULIA_DIR_1_10%" />
</parameters>
<build-runners>
<runner id="RUNNER_2427" name="Print versions" type="simpleRunner">
<parameters>
<param name="script.content"><![CDATA[%env.JULIA_1_9% --version
pixi --version]]></param>
<param name="teamcity.step.mode" value="default" />
<param name="use.custom.script" value="true" />
</parameters>
</runner>
<runner id="RUNNER_2415" name="Set up pixi" type="simpleRunner">
<parameters>
<param name="script.content" value="pixi run install-without-pre-commit" />
Expand All @@ -35,7 +26,7 @@ pixi --version]]></param>
</runner>
<runner id="RUNNER_2416" name="Build binary" type="simpleRunner">
<parameters>
<param name="script.content"><![CDATA[set Path=%env.JULIA_DIR_1_9%;%env.Path%
<param name="script.content"><![CDATA[set Path=%julia_dir%;%env.Path%
pixi run build-libribasim]]></param>
<param name="teamcity.build.workingDir" value="ribasim" />
<param name="teamcity.step.mode" value="default" />
Expand Down Expand Up @@ -90,4 +81,3 @@ pixi run build-libribasim]]></param>
<cleanup />
</settings>
</build-type>

Loading

0 comments on commit 8e67335

Please sign in to comment.