resolved comment non_positive_allocation_network_id()

Deltares · Feb 1, 2024 · df322b5 · df322b5
1 parent 6965280
commit df322b5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/core/src/create.jl b/core/src/create.jl
@@ -199,7 +199,7 @@ const nonconservative_nodetypes =
 function generate_allocation_models!(p::Parameters, config::Config)::Nothing
     (; graph, allocation_models) = p
 
-    errors = non_positive_id(graph)
+    errors = non_positive_allocation_network_id(graph)
 
     if errors
         error("Allocation network initialization failed.")

diff --git a/core/src/validation.jl b/core/src/validation.jl
@@ -673,7 +673,7 @@ function incomplete_subnetwork(graph::MetaGraph, node_ids::Dict{Int, Set{NodeID}
     return errors
 end
 
-function non_positive_id(graph::MetaGraph)::Bool
+function non_positive_allocation_network_id(graph::MetaGraph)::Bool
     errors = false
     for allocation_network_id in keys(graph[].node_ids)
         if (allocation_network_id <= 0)

diff --git a/core/test/create_test.jl b/core/test/create_test.jl
@@ -34,7 +34,7 @@
 
     logger = TestLogger()
     with_logger(logger) do
-        Ribasim.non_positive_id(graph)
+        Ribasim.non_positive_allocation_network_id(graph)
     end
 
     @test length(logger.logs) == 2