Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LinearResistance capacity in allocation #1128

Closed
visr opened this issue Feb 15, 2024 · 0 comments · Fixed by #1182
Closed

Use LinearResistance capacity in allocation #1128

visr opened this issue Feb 15, 2024 · 0 comments · Fixed by #1182
Assignees
@SouthEndMusic
Labels
allocation Allocation layer

Comments

@visr
Copy link
Member

visr commented Feb 15, 2024

What
Allocation does not limit LinearResistance capacity when max_flow_rate is set.

Why
I forgot about this in #1100.

How
Adding capacities just like is done for Pump etc.
@visr visr added the allocation Allocation layer label Feb 15, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Feb 15, 2024
@SnippenE SnippenE moved this from To do to What's next in Ribasim Feb 15, 2024
@SnippenE SnippenE moved this from What's next to Sprint backlog in Ribasim Feb 15, 2024
@visr visr added bug and removed bug labels Feb 15, 2024
@SouthEndMusic SouthEndMusic self-assigned this Feb 26, 2024
@SouthEndMusic SouthEndMusic moved this from Sprint backlog to 🏗 In progress in Ribasim Feb 26, 2024
@SouthEndMusic SouthEndMusic mentioned this issue Feb 26, 2024
Merged
SouthEndMusic added a commit that referenced this issue Feb 26, 2024
@SouthEndMusic
test is_flow_constraining (#1182)
5b3b85d 
Fixes #1128.

I'm pretty sure this wasn't an issue to begin with, since
`LinearResistance` was automatically detected as a flow restricting node
now that the struct has a `max_flow_rate` field. I just added a test for
the `is_flow_constraining` function to be sure.
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SouthEndMusic SouthEndMusic

Labels
allocation Allocation layer
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test is_flow_constraining Deltares/Ribasim
2 participants
@visr @SouthEndMusic