test is_flow_constraining #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
approved these changes
Feb 26, 2024
core/test/utils_test.jl
Outdated
|
|
||
| for type in Ribasim.nodefields(p) | ||
| node = getfield(p, type) | ||
| println(node) |
core/test/utils_test.jl
Outdated
| @testitem "constrains_from_nodes" begin | ||
| toml_path = normpath(@__DIR__, "../../generated_testmodels/basic/ribasim.toml") | ||
| @test ispath(toml_path) | ||
| model = Ribasim.BMI.initialize(Ribasim.Model, toml_path) |
There was a problem hiding this comment.
Suggested change
| model = Ribasim.BMI.initialize(Ribasim.Model, toml_path) | |
| model = Ribasim.Model(toml_path) |
core/test/utils_test.jl
Outdated
| @@ -299,3 +299,21 @@ end | |||
| 2.0, | |||
| ) === 1.0 | |||
| end | |||
|
|
|||
| @testitem "constrains_from_nodes" begin | |||
There was a problem hiding this comment.
Suggested change
| @testitem "constrains_from_nodes" begin | |
| @testitem "constraints_from_nodes" begin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1128.
I'm pretty sure this wasn't an issue to begin with, since
LinearResistancewas automatically detected as a flow restricting node now that the struct has amax_flow_ratefield. I just added a test for theis_flow_constrainingfunction to be sure.