Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of dependency SmoothInterpolation.jl in favor of the new DataInterpolations.jl release #1625

Closed
SouthEndMusic opened this issue Jul 16, 2024 · 2 comments · Fixed by #1649
Closed

Get rid of dependency SmoothInterpolation.jl in favor of the new DataInterpolations.jl release #1625

SouthEndMusic opened this issue Jul 16, 2024 · 2 comments · Fixed by #1649
Labels
core Issues related to the computational core in Julia dependencies Pull requests that update a dependency file

Comments

@SouthEndMusic
Copy link
Collaborator

All features of SmoothInterpolation and more have been merged and released in DataInterpolations.jl:

https://github.com/SciML/DataInterpolations.jl/releases/tag/v5.3.0

Most notably, we can now do integral inversion via DataInterpolations.jl.
@SouthEndMusic SouthEndMusic added dependencies Pull requests that update a dependency file core Issues related to the computational core in Julia labels Jul 16, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Jul 16, 2024
@SouthEndMusic SouthEndMusic changed the title Get rid of dependency SmoothInterpolation.jl in favor of the new DataInterpolations.jl Get rid of dependency SmoothInterpolation.jl in favor of the new DataInterpolations.jl release Jul 16, 2024
@SouthEndMusic
Copy link
Collaborator Author

I had to pin the DataInterpolations.jl version to 5.2.0 in #1602 as the new version breaks some things.

@Jingru923
Copy link
Contributor

Jingru923 commented Jul 16, 2024 •
edited
Loading

The invert_integral can be replaced and issue #1621 can be addressed

@SouthEndMusic SouthEndMusic mentioned this issue Jul 22, 2024
Merged
visr added a commit that referenced this issue Jul 28, 2024
@SouthEndMusic @visr
Remove SmoothInterpolation as a dependency (#1649)
dc4aeac 
Fixes #1625. Some upstream
issues came out of this:

SciML/DataInterpolations.jl#301
SciML/DataInterpolations.jl#302
SciML/DataInterpolations.jl#303

---------

Co-authored-by: Martijn Visser <[email protected]>
@github-project-automation github-project-automation bot moved this from To do to ✅ Done in Ribasim Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues related to the computational core in Julia dependencies Pull requests that update a dependency file
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove SmoothInterpolation as a dependency Deltares/Ribasim
2 participants
@Jingru923 @SouthEndMusic