Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SmoothInterpolation as a dependency #1649

Merged
merged 7 commits into from
Jul 28, 2024
Merged

Remove SmoothInterpolation as a dependency #1649

merged 7 commits into from
Jul 28, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

@SouthEndMusic SouthEndMusic commented Jul 22, 2024 •
edited
Loading

@visr visr mentioned this pull request Jul 23, 2024
Open
@SouthEndMusic SouthEndMusic mentioned this pull request Jul 24, 2024
Merged
@SouthEndMusic
Copy link
Collaborator Author

With SciML/DataInterpolations.jl#315 the ReadOnlyArray wrappers are removed again, and we should do cache_parameters = true to get the performance benefit. For LinearInterpolation appending data is still supported in that case, see https://github.com/SciML/DataInterpolations.jl/blob/master/src/online.jl.

@visr
Copy link
Member

visr commented Jul 28, 2024

Ok, how about we fix to 5.3.1 with f470d24. Then we can merge this, if you agree with my commits, and implement your comments once a new release is out.

@SouthEndMusic
Copy link
Collaborator Author

Looks like you snuck some unrelated changes in there, but it's fine by me to merge this now

@visr
Copy link
Member

visr commented Jul 28, 2024

Oh you mean JULIA_SSL_CA_ROOTS_PATH ? I actually needed that to pass CI when checking out the master branch of DataInterpolations (or any non-released package), otherwise there was a download error. So that's good to have even if we currently don't need unreleased packages.

@visr visr merged commit dc4aeac into main Jul 28, 2024
24 of 25 checks passed
@visr visr deleted the remove_smoothinterpolation_dependency branch July 28, 2024 20:00
@visr visr mentioned this pull request Jul 29, 2024
Merged
Jingru923 pushed a commit that referenced this pull request Jul 29, 2024
@visr
Delwaq pixi run install-ci (#1664)
50f96b6 
Does not fix a regression from #1656. I thought it said `pixi run
install`, but it was `pixi install`.

The Delwaq regression may also be related to
#1649
@visr visr mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of dependency SmoothInterpolation.jl in favor of the new DataInterpolations.jl release
2 participants
@SouthEndMusic @visr