-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Arrow input tables #170
Comments
This was referenced Jun 14, 2023
Closed
Will add/update a testmodel that writes an arrow file in #731, which will implicitly test it in Julia as well. |
Ok, nice. It'd say fixing the Julia side of things is out of scope of #731 though, it's already large enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It should work already in the core, but since there are no tests let's assume it's not working. Only the output tables are written to Arrow.
The example models in
conftest.py
currently write all input tables to the GeoPackage file. This is whatmodel.write(path)
does. Usually Arrow input tables are mainly interesting for large (time-dependent) tables, but we need to make sure it is working in CI.I see the
class InputMixin
has_write_arrow
and_write_geopackage
that are both not used. Insteadwrite
loops over the underlying tables and writes them one-by-one to GeoPackage. Perhaps we need something like an attribute in all tables (e.g. classes that inherit frompa.SchemaModel
, that determines if it should be written to GeoPackage (the default) or Arrow.A minimum first test is added here, which contains a utility function to convert GeoPackage tables to Arrow.
https://github.com/Deltares/Ribasim/pull/187/files#diff-dd42657be5ede608d919dd58408933bac74a4661098f89d8b48dc53adf0478d7
The text was updated successfully, but these errors were encountered: