-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support arrow input. #798
Support arrow input. #798
Conversation
Ah, great, surprised that this just works on the Julia side. Indeed since this is input I'd say the path has to be relative to both the TOML directory and the optional Actually, I see |
I can add the input_dir, and leave the relative_dir for now, as I think it's unused and should probably be removed. Other naming things should probably be refined and changed in another PR. |
Great, thanks. I thought |
Ok, I've now added using input_dir in both reading and writing. I've also added a test in Python to check we can read arrow files back in again (from the relative input_path). |
Thanks for the review, all addressed now. |
Fixes #170
What do we support in terms of input/relative dir as put in the settings? Currently, this ignores the setting completely.