Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arrow input. #798

Merged
merged 7 commits into from
Nov 17, 2023
Merged

Support arrow input. #798

merged 7 commits into from
Nov 17, 2023

Conversation

evetion
Copy link
Member

@evetion evetion commented Nov 16, 2023

Fixes #170

What do we support in terms of input/relative dir as put in the settings? Currently, this ignores the setting completely.

@visr
Copy link
Member

visr commented Nov 16, 2023

Ah, great, surprised that this just works on the Julia side. Indeed since this is input I'd say the path has to be relative to both the TOML directory and the optional input_dir.

Actually, I see input_dir and results_dir are missing from docs.toml, if you feel like addressing that as well.

@evetion
Copy link
Member Author

evetion commented Nov 17, 2023

Ah, great, surprised that this just works on the Julia side. Indeed since this is input I'd say the path has to be relative to both the TOML directory and the optional input_dir.

Actually, I see input_dir and results_dir are missing from docs.toml, if you feel like addressing that as well.

I can add the input_dir, and leave the relative_dir for now, as I think it's unused and should probably be removed. Other naming things should probably be refined and changed in another PR.

@visr
Copy link
Member

visr commented Nov 17, 2023

Great, thanks. I thought relative_dir isn't really a TOML key, it is just a way on the Julia side to interpret all paths relative to the TOML.

@evetion
Copy link
Member Author

evetion commented Nov 17, 2023

Ok, I've now added using input_dir in both reading and writing. I've also added a test in Python to check we can read arrow files back in again (from the relative input_path).

@evetion evetion requested a review from Hofer-Julian November 17, 2023 10:08
.vscode/settings.json Outdated Show resolved Hide resolved
core/test/docs.toml Outdated Show resolved Hide resolved
docs/python/examples.ipynb Show resolved Hide resolved
python/ribasim/ribasim/input_base.py Outdated Show resolved Hide resolved
@evetion
Copy link
Member Author

evetion commented Nov 17, 2023

Thanks for the review, all addressed now.

@evetion evetion mentioned this pull request Nov 17, 2023
3 tasks
@evetion evetion merged commit 50c8675 into main Nov 17, 2023
15 checks passed
@evetion evetion deleted the feat/arrow-input branch November 17, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Arrow input tables
3 participants