Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test python 3.12 #654

Closed
visr opened this issue Oct 9, 2023 · 2 comments · Fixed by #891
Closed

test python 3.12 #654

visr opened this issue Oct 9, 2023 · 2 comments · Fixed by #891
Labels
CI/CD Continuous Integration/Continuous deployment dependencies Pull requests that update a dependency file python Relates to one of the Ribasim python packages

Comments

@visr
Copy link
Member

visr commented Oct 9, 2023

It only came out a week or two ago, so our dependencies aren't there yet. pyogrio should have a 3.12 build in the next release after 0.6.0, I'm watching that for releases, then we can try again. We can also directly update our pixi.lock so people use it.

Came up in #652 (comment)
@visr visr added CI/CD Continuous Integration/Continuous deployment python Relates to one of the Ribasim python packages dependencies Pull requests that update a dependency file labels Oct 9, 2023
@github-project-automation github-project-automation bot moved this to To do in Ribasim Oct 9, 2023
visr added a commit that referenced this issue Oct 31, 2023
@visr
Update to python 3.12, pandas 2.1.2
6fe40b2 
Fixes #654
Fixes #645

I ran `pixi add pandas=2.1.2 python=3.12 pyogrio=0.7.2` using pixi v0.5.0 so as not to update the lockfile format.

The new pyogrio release is needed to be able to use Python 3.12. We only update the Python version in the Pixi lockfile and on CI, this does not change our minimum supported Python version.

The pandas update to 2.1.2 fixes a regression present in 2.1.0 and 2.1.1, no further changes were needed in our code.
@visr visr mentioned this issue Oct 31, 2023
Merged
@visr
Copy link
Member Author

visr commented Oct 31, 2023

#713 addresses a large part of this. To fix this we just need to revert 5d2fb8f, which we should be able to do when pyarrow 14 is out, see https://pypi.org/project/pyarrow/#history.

Hofer-Julian pushed a commit that referenced this issue Oct 31, 2023
@visr
Update to python 3.12, pandas 2.1.2 (#713)
84d44b6 
Part of #654
Fixes #645

I ran `pixi add pandas=2.1.2 python=3.12 pyogrio=0.7.2` using pixi
v0.5.0 so as not to update the lockfile format.

The new pyogrio release is needed to be able to use Python 3.12. We only
update the Python version in the Pixi lockfile and on CI, this does not
change our minimum supported Python version.

The pandas update to 2.1.2 fixes a regression present in 2.1.0 and
2.1.1, no further changes were needed in our code.

@Hofer-Julian I simply removed the `pandas < 2.1` restriction in the
pyproject.toml, assuming that is fine since with the release of pandas
2.1.2 most people won't get 2.1.0 or 2.1.1 anymore, though I guess we
could exclude multiple patch releases.
visr added a commit that referenced this issue Nov 13, 2023
@visr
Update to python 3.12, pandas 2.1.2 (#713)
31275b7 
Part of #654
Fixes #645

I ran `pixi add pandas=2.1.2 python=3.12 pyogrio=0.7.2` using pixi
v0.5.0 so as not to update the lockfile format.

The new pyogrio release is needed to be able to use Python 3.12. We only
update the Python version in the Pixi lockfile and on CI, this does not
change our minimum supported Python version.

The pandas update to 2.1.2 fixes a regression present in 2.1.0 and
2.1.1, no further changes were needed in our code.

@Hofer-Julian I simply removed the `pandas < 2.1` restriction in the
pyproject.toml, assuming that is fine since with the release of pandas
2.1.2 most people won't get 2.1.0 or 2.1.1 anymore, though I guess we
could exclude multiple patch releases.
@Hofer-Julian Hofer-Julian moved this from To do to What's next in Ribasim Dec 7, 2023
@deltamarnix
Copy link
Contributor

This issue only requires us to update the test matrix:

Ribasim/.github/workflows/python_tests.yml

Line 25 in aa37a01

- "3.11"

@Hofer-Julian Hofer-Julian moved this from What's next to Sprint backlog in Ribasim Dec 13, 2023
Hofer-Julian added a commit that referenced this issue Dec 13, 2023
@Hofer-Julian
Test Ribasim Python with Python 3.12
39ea679 
Fixes #654
@Hofer-Julian Hofer-Julian mentioned this issue Dec 13, 2023
Merged
@Hofer-Julian Hofer-Julian moved this from Sprint backlog to 🏗 In progress in Ribasim Dec 13, 2023
Hofer-Julian added a commit that referenced this issue Dec 13, 2023
@Hofer-Julian
Test Ribasim Python with Python 3.12 (#891)
5e58987 
Fixes #654
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/CD Continuous Integration/Continuous deployment dependencies Pull requests that update a dependency file python Relates to one of the Ribasim python packages
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test Ribasim Python with Python 3.12 Deltares/Ribasim
2 participants
@visr @deltamarnix