Update to python 3.12, pandas 2.1.2 #713
Conversation
Fixes #654 Fixes #645 I ran `pixi add pandas=2.1.2 python=3.12 pyogrio=0.7.2` using pixi v0.5.0 so as not to update the lockfile format. The new pyogrio release is needed to be able to use Python 3.12. We only update the Python version in the Pixi lockfile and on CI, this does not change our minimum supported Python version. The pandas update to 2.1.2 fixes a regression present in 2.1.0 and 2.1.1, no further changes were needed in our code.
Just like in the pixi tasks. pip was failing to build pyarrow in CI.
This reverts commit 37fa611. The deps are needed since we don't use pixi here.
|
Locally tests pass for me, but that is using the pixi environment. On CI we don't use pixi yet but pip, leading to |
pyarrow doesn't provide python 3.12 wheels yet. |
|
Ok support for that is merged upstream, we just need to wait for a pyarrow 14 release on PyPI. |
I'd be fine with only merging the pixi part and start testing 3.12 for Ribasim Python as soon as the pyarrow wheels for 3.12 are out. |
|
Sounds good, done. I kept pre-commit CI on 3.12 as well since that is also working fine. |
Part of #654 Fixes #645 I ran `pixi add pandas=2.1.2 python=3.12 pyogrio=0.7.2` using pixi v0.5.0 so as not to update the lockfile format. The new pyogrio release is needed to be able to use Python 3.12. We only update the Python version in the Pixi lockfile and on CI, this does not change our minimum supported Python version. The pandas update to 2.1.2 fixes a regression present in 2.1.0 and 2.1.1, no further changes were needed in our code. @Hofer-Julian I simply removed the `pandas < 2.1` restriction in the pyproject.toml, assuming that is fine since with the release of pandas 2.1.2 most people won't get 2.1.0 or 2.1.1 anymore, though I guess we could exclude multiple patch releases.
Part of #654
Fixes #645
I ran
pixi add pandas=2.1.2 python=3.12 pyogrio=0.7.2using pixi v0.5.0 so as not to update the lockfile format.The new pyogrio release is needed to be able to use Python 3.12. We only update the Python version in the Pixi lockfile and on CI, this does not change our minimum supported Python version.
The pandas update to 2.1.2 fixes a regression present in 2.1.0 and 2.1.1, no further changes were needed in our code.
@Hofer-Julian I simply removed the
pandas < 2.1restriction in the pyproject.toml, assuming that is fine since with the release of pandas 2.1.2 most people won't get 2.1.0 or 2.1.1 anymore, though I guess we could exclude multiple patch releases.