-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve input subgrid_id
in output
#895
Comments
visr
added a commit
that referenced
this issue
May 14, 2024
visr
added a commit
that referenced
this issue
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What
The subgrid feature added in #674 takes
subgrid_id
[x,y,z]
, but does not preserve them, and writes them out as[1,2,3]
.Why
We don't want to require allowing only
1:n
consecutive subgrid IDs. So we need to preserve them.How
We add the IDs to the
struct Subgrid
, and use these insubgrid_level_table
as well. We should sort by subgrid ID as documented in https://deltares.github.io/Ribasim/core/usage.html#basin-subgridAdditional context
Came up in #885 (comment)
The text was updated successfully, but these errors were encountered: