Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve input subgrid_id in output #895

Closed
visr opened this issue Dec 14, 2023 · 0 comments · Fixed by #1466
Closed

Preserve input subgrid_id in output #895

visr opened this issue Dec 14, 2023 · 0 comments · Fixed by #1466

Comments

@visr
Copy link
Member

visr commented Dec 14, 2023

What
The subgrid feature added in #674 takes subgrid_id [x,y,z], but does not preserve them, and writes them out as [1,2,3].

Why
We don't want to require allowing only 1:n consecutive subgrid IDs. So we need to preserve them.

How
We add the IDs to the struct Subgrid, and use these in subgrid_level_table as well. We should sort by subgrid ID as documented in https://deltares.github.io/Ribasim/core/usage.html#basin-subgrid

Additional context
Came up in #885 (comment)

@visr visr added the bug label Dec 14, 2023
@github-project-automation github-project-automation bot moved this to To do in Ribasim Dec 14, 2023
@SnippenE SnippenE moved this from To do to What's next in Ribasim Feb 22, 2024
visr added a commit that referenced this issue May 14, 2024
@SnippenE SnippenE moved this from What's next to 🏗 In progress in Ribasim May 16, 2024
@SnippenE SnippenE moved this from 🏗 In progress to 👀 In review in Ribasim May 16, 2024
visr added a commit that referenced this issue May 16, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Ribasim May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant