Don't require consecutive Node IDs #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
commented
Dec 11, 2023
| @@ -248,7 +248,7 @@ function create_callbacks( | |||
| save_subgrid_level, | |||
| saved_subgrid_level; | |||
| saveat, | |||
| save_start = false, | |||
| save_start = true, | |||
There was a problem hiding this comment.
@Huite I'm now saving initial subgrid levels as well, just like the regular basin.arrow. I assume you copied this from flow, which is undefined at t0 so we don't save it.
Comment on lines
+82
to
+83
| # TODO The original subgrid IDs are lost and mapped to 1, 2, 3 | ||
| @test subgrid.subgrid_id[1:3] == [11, 22, 33] broken = true |
There was a problem hiding this comment.
@Huite I assume you want to keep the original subgrid IDs right? If so let's create an issue to fix this. We'd have to store them in the struct Subgrid.
There was a problem hiding this comment.
Yes, I think we should keep them around. Are you opening an issue?
Hofer-Julian
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #694
It basically was already fixed in the metagraphs refactor, I just had to remove the validation check from Python.
This also adds support for 0, but not negative IDs, as I feel those could be confusing.
I used the trivial model to add some ID variations, and directly added some tests of the Arrow file results that we didn't really have yet.