Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove using S for storage (use u) #1003

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Remove using S for storage (use u) #1003

merged 1 commit into from
Jan 31, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #968.

@Jingru923
Copy link
Contributor

I see the new letter you are using is also used somewhere. For example, in equation section, equation (1) has also 'u'. In numerical considerations, equation (1), there is also 'u'.
For me, I think the doc is less confusing than before, it's improving. However, how do you think about the overlapping of 'u'? @SouthEndMusic

@SouthEndMusic
Copy link
Collaborator Author

@Jingru923 these all refer to the same $u$, which is the state vector of the model.

@Jingru923
Copy link
Contributor

So the storages are states?

@SouthEndMusic
Copy link
Collaborator Author

SouthEndMusic commented Jan 31, 2024

So the storages are states?

Indeed, the system of differential equations which is solved by the Ribasim core is formulated in terms of the storages of the basins (and the integral term of the PID controller).

@SouthEndMusic SouthEndMusic merged commit 5f5e09a into main Jan 31, 2024
19 checks passed
@SouthEndMusic SouthEndMusic deleted the remove_S_confusion branch January 31, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple define of variable "S"
2 participants