Fold docs/Project.toml into root/Project.toml #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There isn't really added value to having it separately anymore, this is simpler.
Hofer-Julian
approved these changes
Jan 31, 2024
visr
added a commit
that referenced
this pull request
Jan 31, 2024
visr
added a commit
that referenced
this pull request
Feb 1, 2024
This attempts to simplifiy our Julia project and build setup. Where possible, existing projects are moved into the root project like in #1014. All core dependencies are now also direct root dependencies to make using the root project more convenient for development. While working on this I realized that we can remove the `libribasim` and `ribasim_cli` projects entirely. `libribasim` is now a module of the Ribasim package, and `ribasim_cli` already was just a tiny wrapper around `Ribasim.main`. The content of the README.md files from those two folders now reside in the `build_lib` and `build_app` docstring. Since that left only the `create_binaries` folder under `/build`, I collapsed that level out. `create_binaries` is no longer a package, but the code is still used, but now simply directly included in `build.jl`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't really added value to having it separately anymore, this is simpler.