Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pixi lock file #1025

Closed
wants to merge 2 commits into from
Closed

Update pixi lock file #1025

wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 1, 2024

Update pixi dependencies to the latest version.

Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to fix these mypy issues first.

python/ribasim/ribasim/geometry/node.py:81: error: Value of type "DataFrame[NodeSchema] | None" is not indexable  [index]
python/ribasim/ribasim/geometry/node.py:110: error: Item "None" of "DataFrame[NodeSchema] | None" has no attribute "index"  [union-attr]
python/ribasim/ribasim/geometry/node.py:111: error: Item "None" of "DataFrame[NodeSchema] | None" has no attribute "geometry"  [union-attr]
python/ribasim/ribasim/geometry/node.py:184: error: Item "None" of "DataFrame[NodeSchema] | None" has no attribute "groupby"  [union-attr]
python/ribasim/ribasim/geometry/node.py:19[7](https://github.com/Deltares/Ribasim/actions/runs/7735658359/job/21091697315?pr=1025#step:5:8): error: Value of type "DataFrame[NodeSchema] | None" is not indexable  [index]
python/ribasim/ribasim/geometry/node.py:19[8](https://github.com/Deltares/Ribasim/actions/runs/7735658359/job/21091697315?pr=1025#step:5:9): error: Item "None" of "DataFrame[NodeSchema] | None" has no attribute "index"  [union-attr]
python/ribasim/ribasim/geometry/edge.py:43: error: Item "None" of "DataFrame[EdgeSchema] | None" has no attribute "edge_type"  [union-attr]
python/ribasim/ribasim/geometry/edge.py:77: error: Value of type "DataFrame[EdgeSchema] | None" is not indexable  [index]
python/ribasim/ribasim/geometry/edge.py:78: error: Value of type "DataFrame[EdgeSchema] | None" is not indexable  [index]
python/ribasim/ribasim/geometry/edge.py:81: error: Value of type "DataFrame[EdgeSchema] | None" is not indexable  [index]
python/ribasim/ribasim/geometry/edge.py:84: error: Item "None" of "DataFrame[EdgeSchema] | None" has no attribute "geometry"  [union-attr]
python/ribasim/ribasim/geometry/edge.py:[9](https://github.com/Deltares/Ribasim/actions/runs/7735658359/job/21091697315?pr=1025#step:5:10)3: error: Argument 1 to "len" has incompatible type "DataFrame[EdgeSchema] | None"; expected "Sized"  [arg-type]
python/ribasim/ribasim/model.py:485: error: Item "None" of "DataFrame[NodeSchema] | None" has no attribute "loc"  [union-attr]
python/ribasim/ribasim/model.py:495: error: Value of type "DataFrame[EdgeSchema] | None" is not indexable  [index]
python/ribasim/ribasim/model.py:496: error: Item "None" of "DataFrame[EdgeSchema] | None" has no attribute "from_node_id"  [union-attr]
python/ribasim/ribasim/model.py:500: error: Item "None" of "DataFrame[NodeSchema] | None" has no attribute "loc"  [union-attr]

@visr visr closed this Feb 2, 2024
@visr visr deleted the update/pixi-lock branch February 2, 2024 11:02
visr added a commit that referenced this pull request Feb 2, 2024
- Update `pixi.lock`
- Add asserts to satisfy mypy

This is #1025 (not #1064 since that moves to the new pixi.lock format
version) but with the fixes needed for mypy.

---------

Co-authored-by: GitHub <[email protected]>
Co-authored-by: Marnix Kraus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants