Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove update_timestep in Ribasim Python #1099

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Remove update_timestep in Ribasim Python #1099

merged 1 commit into from
Feb 8, 2024

Conversation

Hofer-Julian
Copy link
Contributor

Fixes #1093

@Hofer-Julian Hofer-Julian requested a review from visr February 8, 2024 16:05
visr
visr approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now Solver(saveat=3600.0), which saves every hour. We could support fancy datetime.timedelta stuff for that just like we used to for update_timestep, but as-is is fine as well.

@visr visr merged commit 6c6969f into main Feb 8, 2024
21 checks passed
@visr visr deleted the remove-update-timestep branch February 8, 2024 16:44
Hofer-Julian added a commit that referenced this pull request Feb 9, 2024
@Hofer-Julian
Follow up to #1099
59bc023 
I forgot to actually remove the property
visr pushed a commit that referenced this pull request Feb 9, 2024
@Hofer-Julian
Follow up to #1099 (#1102)
a83baa5 
I forgot to actually remove the property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update_timestep in Ribasim Python's Model is not used
2 participants
@Hofer-Julian @visr