Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize code among files in core #1101

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Reorganize code among files in core #1101

merged 2 commits into from
Feb 9, 2024

Conversation

visr
Copy link
Member

@visr visr commented Feb 8, 2024

Apologies for the huge diff and the conflicts this will create, but a reorganization of the core code was overdue. This only moves code, there are no other changes.

A rough overview of the changes:

  • validation.jl: split out schemas.jl, and moved all validation functions in
  • solve.jl: split out parameter structs to parameter.jl
  • create.jl and io.jl: split out into read.jl and write.jl
  • const.jl: move single const to write.jl
  • add callback.jl for solver callback related code
  • add graph.jl for graph related code
  • bmi.jl: split out all non-BMI functions, moved large function bodies elsewhere
  • utils.jl: split out add sparsity.jl for Jacobian sparsity generation

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really easy to review this, but the mentioned changes look fine.
Also the tests are green.

@visr
Copy link
Member Author

visr commented Feb 9, 2024

Ok I'll go ahead and merge this. I can help updating open PRs if needed.

@visr visr merged commit 94a02aa into main Feb 9, 2024
21 checks passed
@visr visr deleted the restructure branch February 9, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants